Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Schema for createCustomer does not match validation requirements #28570

Closed
magento-engcom-team opened this issue Jun 5, 2020 · 6 comments · Fixed by #28888
Closed
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: GraphQL Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

The schema for the createCustomer mutation shows the input object as a whole as required but it does not show the individual required fields. For example, I tried to make an account passing ONLY the email and password but received an error after submission that said first name and last name were required.

https://i.gyazo.com/baffd808d33594f6aa1f9ef785cac540.png

After checking the schema, it does not look like any of the props within the input object are listed as required. Fixing the schema will help catch errors ahead of time and during development of features.

https://i.gyazo.com/47babb76479f71ee87e5e46051c9b42e.png

@magento-engcom-team magento-engcom-team added Progress: ready for dev Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@ghost ghost added this to Ready for Dev in Community Backlog Jun 5, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 5, 2020
@michalderlatka
Copy link
Contributor

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @michalderlatka! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@michalderlatka
Copy link
Contributor

@magento I am working on this

@nrkapoor nrkapoor moved this from Ready for Dev to Good First Issue in Community Backlog Jun 10, 2020
@michalderlatka michalderlatka moved this from Good First Issue to Dev in Progress in Community Backlog Jun 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 20, 2020

Hi @cpartica. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Dev in Progress to Ready for Dev in Community Backlog Jun 20, 2020
@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 20, 2020
@ghost ghost removed the Progress: ready for dev label Jun 20, 2020
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 25, 2020
@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 25, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jun 30, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jul 7, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jul 9, 2020
michalderlatka added a commit to michalderlatka/magento2 that referenced this issue Jul 13, 2020
@magento-engcom-team
Copy link
Contributor Author

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 16, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jul 16, 2020
@magento-engcom-team magento-engcom-team added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: GraphQL Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

Successfully merging a pull request may close this issue.

4 participants