32574 GraphQL: move items from cart to gift registry #8929

khrystynastolbova · 2021-05-10T16:54:41Z

Purpose of this pull request

This pull request (PR) adds the moveCartItemsToGiftRegistry mutation.

Affected DevDocs pages

...

Links to Magento source code

magento/partners-magento2ee/pull/540

Issue magento/magento2#32574

whatsnew
Added the moveCartItemsToGiftRegistry mutation.

BarnyShergold

Great addition!

BarnyShergold · 2021-05-11T08:28:14Z

src/_includes/graphql/gift-registry-items-user-error.md

+
+Attribute |  Data Type | Description
+--- | --- | ---
+`code`  | GiftRegistryItemsUserErrorType! | A gift registry-specific error code. Possible values include `OUT_OF_STOCK`, `NOT_FOUND` and `UNDEFINED`


Suggested change

`code` | GiftRegistryItemsUserErrorType! | A gift registry-specific error code. Possible values include `OUT_OF_STOCK`, `NOT_FOUND` and `UNDEFINED`

`code` | GiftRegistryItemsUserErrorType! | A gift registry specific error code. Possible values include `OUT_OF_STOCK`, `NOT_FOUND` and `UNDEFINED`

BarnyShergold · 2021-05-11T08:34:10Z

src/_includes/graphql/gift-registry-items-user-error.md

+`message` | String! | A localized error message
+`product_uid` | ID | The unique ID of the product containing an error
+`gift_registry_item_uid` | ID | The unique ID of the gift registry item containing an error
+`gift_registry_uid` | ID | The unique ID of the `Gift registry` object containing an error


Consistent with page below

Suggested change

`gift_registry_uid` | ID | The unique ID of the `Gift registry` object containing an error

`gift_registry_uid` | ID | The unique ID of the `GiftRegistry` object containing an error

BarnyShergold · 2021-05-11T08:34:46Z

src/guides/v2.4/graphql/mutations/move-cart-items-to-gift-registry.md

+
+## Output attributes
+
+The `MoveCartItemsToGiftRegistryOutput` object can contain the following attributes.


Suggested change

The `MoveCartItemsToGiftRegistryOutput` object can contain the following attributes.

The `MoveCartItemsToGiftRegistryOutput` object can contain the following attributes:

BarnyShergold · 2021-05-11T08:34:55Z

src/guides/v2.4/graphql/mutations/move-cart-items-to-gift-registry.md

+
+## Input attributes
+
+The `moveCartItemsToGiftRegistry` mutation requires the following input.


Suggested change

The `moveCartItemsToGiftRegistry` mutation requires the following input.

The `moveCartItemsToGiftRegistry` mutation requires the following input:

khrystynastolbova · 2021-05-11T10:24:10Z

Hi @BarnyShergold,
Thanks for your review and suggestions. The mentioned changes are done.

keharper · 2021-05-13T03:07:16Z

@khrystynastolbova We need to account for the new interfaces somehow, but I'm not sure how to do it while just looking at the schema. They're too small to warrant their own topics. I'll get back to you in a few days, after I've had a chance to test the new mutation.

khrystynastolbova · 2021-05-19T07:11:46Z

@khrystynastolbova We need to account for the new interfaces somehow, but I'm not sure how to do it while just looking at the schema. They're too small to warrant their own topics. I'll get back to you in a few days, after I've had a chance to test the new mutation.

Hi @keharper! I see I missed the new interfaces. They are too small but other mutations will probably implement these interfaces. So maybe it would be better to move them to separate files?

khrystynastolbova · 2021-05-19T07:18:05Z

src/guides/v2.4/graphql/mutations/move-cart-items-to-gift-registry.md

+## Output attributes
+
+The `MoveCartItemsToGiftRegistryOutput` object can contain the following attributes:
+
+Attribute |  Data Type | Description
+--- | --- | ---
+`gift_registry` | [GiftRegistry!](#GiftRegistry) | The gift registry containing the moved items
+`status` | Boolean! | Indicates whether the attempt to move the cart items to the gift registry was successful
+`user_errors` | [[GiftRegistryItemsUserError!](#GiftRegistryItemsUserError)] | An array of errors encountered while moving items from the cart to the gift registry


Suggested change

## Output attributes

The `MoveCartItemsToGiftRegistryOutput` object can contain the following attributes:

Attribute | Data Type | Description

--- | --- | ---

`gift_registry` | [GiftRegistry!](#GiftRegistry) | The gift registry containing the moved items

`status` | Boolean! | Indicates whether the attempt to move the cart items to the gift registry was successful

`user_errors` | [[GiftRegistryItemsUserError!](#GiftRegistryItemsUserError)] | An array of errors encountered while moving items from the cart to the gift registry

### MoveCartItemsToGiftRegistryOutput attributes {#MoveCartItemsToGiftRegistryOutput}

The `MoveCartItemsToGiftRegistryOutput` object implements [`GiftRegistryOutputInterface`](#GiftRegistryOutputInterface) and [`GiftRegistryItemUserErrorInterface`](#GiftRegistryItemUserErrorInterface).

### GiftRegistryOutputInterface attributes {#GiftRegistryOutputInterface}

{% include graphql/gift-registry-output-interface.md %}

### GiftRegistryItemUserErrorInterface attributes {#GiftRegistryItemUserErrorInterface}

{% include graphql/gift-registry-item-user-error-interface.md %}

keharper · 2021-05-24T16:45:44Z

@khrystynastolbova This PR looks like it's complete technically. Please add the following lines to the header section of move-cart-items-to-gift-registry.md.

contributor_name: Atwix
contributor_link: https://www.atwix.com/

…hub.com:khrystynastolbova/devdocs into 32574_GQL_move_items_from_cart_to_gift_registry

khrystynastolbova · 2021-05-25T06:49:34Z

@khrystynastolbova This PR looks like it's complete technically. Please add the following lines to the header section of move-cart-items-to-gift-registry.md.
contributor_name: Atwix
contributor_link: https://www.atwix.com/

Thanks, @keharper. Done.

keharper · 2021-05-25T13:29:23Z

@magento import code to magento-devdocs/devdocs

magento-engcom-team · 2021-05-25T13:31:04Z

@keharper the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8929.

ghost · 2021-05-25T18:10:41Z

Hi @khrystynastolbova, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

32574 GraphQL: move items from cart to gift registry

f11fd61

magento-engcom-team added Partner: Atwix partners-contribution PR created by Magento partner labels May 10, 2021

m2-community-project bot added the Progress: ready for review label May 10, 2021

khrystynastolbova added 3 commits May 10, 2021 19:59

remove trailing spaces

e3660ed

remove trailing spaces

6faee2c

correct the mistake

4af8eed

dobooth requested a review from keharper May 10, 2021 18:38

BarnyShergold suggested changes May 11, 2021

View reviewed changes

m2-community-project bot assigned BarnyShergold May 11, 2021

m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels May 11, 2021

BarnyShergold added New Topic A major update published as an entirely new document Progress: ready for review and removed Progress: changes requested labels May 11, 2021

m2-community-project bot added Progress: changes requested and removed Progress: ready for review labels May 11, 2021

small changes

d88fb8f

BarnyShergold approved these changes May 11, 2021

View reviewed changes

m2-community-project bot added Progress: approved and removed Progress: changes requested labels May 11, 2021

keharper self-assigned this May 12, 2021

Update gift-registry-items-user-error.md

8a197df

m2-community-project bot added Progress: review and removed Progress: approved labels May 19, 2021

khrystynastolbova commented May 19, 2021

View reviewed changes

khrystynastolbova added 2 commits May 25, 2021 09:42

Add contributor_name

6bc6e32

Merge branch '32574_GQL_move_items_from_cart_to_gift_registry' of git…

62dda15

…hub.com:khrystynastolbova/devdocs into 32574_GQL_move_items_from_cart_to_gift_registry

keharper approved these changes May 25, 2021

View reviewed changes

m2-community-project bot added Progress: approved and removed Progress: review labels May 25, 2021

magento-cicd2 merged commit 00a0600 into magento:2.4.3-develop May 25, 2021

m2-community-project bot added Progress: done and removed Progress: approved labels May 25, 2021

dshevtsov added the 2.4.3 label Aug 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

32574 GraphQL: move items from cart to gift registry #8929

32574 GraphQL: move items from cart to gift registry #8929

khrystynastolbova commented May 10, 2021 •

edited by keharper

Loading

BarnyShergold left a comment

BarnyShergold May 11, 2021

BarnyShergold May 11, 2021

BarnyShergold May 11, 2021

BarnyShergold May 11, 2021

khrystynastolbova commented May 11, 2021

keharper commented May 13, 2021

khrystynastolbova commented May 19, 2021

khrystynastolbova May 19, 2021 •

edited

Loading

keharper commented May 24, 2021 •

edited

Loading

khrystynastolbova commented May 25, 2021 •

edited

Loading

keharper commented May 25, 2021

magento-engcom-team commented May 25, 2021

ghost commented May 25, 2021

	`code` \| GiftRegistryItemsUserErrorType! \| A gift registry-specific error code. Possible values include `OUT_OF_STOCK`, `NOT_FOUND` and `UNDEFINED`
	`code` \| GiftRegistryItemsUserErrorType! \| A gift registry specific error code. Possible values include `OUT_OF_STOCK`, `NOT_FOUND` and `UNDEFINED`

	`gift_registry_uid` \| ID \| The unique ID of the `Gift registry` object containing an error
	`gift_registry_uid` \| ID \| The unique ID of the `GiftRegistry` object containing an error


		## Output attributes

		The `MoveCartItemsToGiftRegistryOutput` object can contain the following attributes.


		## Input attributes

		The `moveCartItemsToGiftRegistry` mutation requires the following input.

32574 GraphQL: move items from cart to gift registry #8929

32574 GraphQL: move items from cart to gift registry #8929

Conversation

khrystynastolbova commented May 10, 2021 • edited by keharper Loading

Purpose of this pull request

Affected DevDocs pages

Links to Magento source code

BarnyShergold left a comment

Choose a reason for hiding this comment

BarnyShergold May 11, 2021

Choose a reason for hiding this comment

BarnyShergold May 11, 2021

Choose a reason for hiding this comment

BarnyShergold May 11, 2021

Choose a reason for hiding this comment

BarnyShergold May 11, 2021

Choose a reason for hiding this comment

khrystynastolbova commented May 11, 2021

keharper commented May 13, 2021

khrystynastolbova commented May 19, 2021

khrystynastolbova May 19, 2021 • edited Loading

Choose a reason for hiding this comment

keharper commented May 24, 2021 • edited Loading

khrystynastolbova commented May 25, 2021 • edited Loading

keharper commented May 25, 2021

magento-engcom-team commented May 25, 2021

ghost commented May 25, 2021

khrystynastolbova commented May 10, 2021 •

edited by keharper

Loading

khrystynastolbova May 19, 2021 •

edited

Loading

keharper commented May 24, 2021 •

edited

Loading

khrystynastolbova commented May 25, 2021 •

edited

Loading