Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on event observer topic #8950

Merged
merged 3 commits into from
May 25, 2021

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented May 19, 2021

Purpose of this pull request

This pull request (PR) includes the below improvements:

  • Added example of subscribing to the custom event.
  • Added information on the list of valid areas for observers.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added an example and table to the Events and observers.

Copy link
Contributor

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition

@ajithkumar-maragathavel
Copy link
Contributor Author

@BarnyShergold Updated the PR with the suggested changes. Thanks

Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajithkumar-maragathavel A few editorial comments. The 3rd column of the table isn't necessary since 6 out 7 descriptions vary by one word.

@ajithkumar-maragathavel
Copy link
Contributor Author

@keharper Thanks for the suggestions. PR updated.

@keharper
Copy link
Contributor

@magento import code to magento-devdocs/devdocs

@magento-engcom-team
Copy link

@keharper the branch with code successfully imported intomagento-devdocs/devdocs repository. Branch name: imported-magento-devdocs-8950.

@keharper keharper added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Technical Updates to the code or processes that alter the technical content of the doc labels May 25, 2021
@magento-cicd2 magento-cicd2 merged commit 74f1621 into magento:master May 25, 2021
@ghost
Copy link

ghost commented May 25, 2021

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Partner: Ziffity partners-contribution PR created by Magento partner Progress: done Technical Updates to the code or processes that alter the technical content of the doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants