MAGECLOUD-2925: Raise additional log message levels (#393)

MAGECLOUD-2925 Raise additional log message levels
magento · Dec 11, 2018 · e517b5c · e517b5c
1 parent a30a51f
commit e517b5c
Show file tree

Hide file tree

Showing 6 changed files with 22 additions and 14 deletions.
diff --git a/src/Process/Build/CompileDi.php b/src/Process/Build/CompileDi.php
@@ -55,12 +55,13 @@ public function execute()
     {
         $verbosityLevel = $this->stageConfig->get(BuildInterface::VAR_VERBOSE_COMMANDS);
 
-        $this->logger->info('Running DI compilation');
+        $this->logger->notice('Running DI compilation');
 
         try {
             $this->shell->execute("php ./bin/magento setup:di:compile {$verbosityLevel} --ansi --no-interaction");
         } catch (ShellException $exception) {
             throw new ProcessException($exception->getMessage(), $exception->getCode(), $exception);
         }
+        $this->logger->notice('End of running DI compilation');
     }
 }
diff --git a/src/Process/Build/RefreshModules.php b/src/Process/Build/RefreshModules.php
@@ -43,12 +43,13 @@ public function __construct(
      */
     public function execute()
     {
-        $this->logger->info('Reconciling installed modules with shared config.');
+        $this->logger->notice('Reconciling installed modules with shared config.');
 
         try {
             $this->config->refresh();
         } catch (ShellException $exception) {
             throw new ProcessException($exception->getMessage(), $exception->getCode(), $exception);
         }
+        $this->logger->notice('End of reconciling modules.');
     }
 }
diff --git a/src/Process/ValidateConfiguration.php b/src/Process/ValidateConfiguration.php
@@ -44,7 +44,7 @@ public function __construct(
      */
     public function execute()
     {
-        $this->logger->info('Validating configuration');
+        $this->logger->notice('Validating configuration');
 
         $maxLevel = 0;
         $messages = [];
@@ -70,7 +70,7 @@ function ($line) {
             }
         }
 
-        $this->logger->info('End of validation');
+        $this->logger->notice('End of validation');
 
         if (!$messages || !$maxLevel) {
             return;

diff --git a/src/Test/Unit/Process/Build/CompileDiTest.php b/src/Test/Unit/Process/Build/CompileDiTest.php
@@ -61,9 +61,12 @@ public function testExecute()
             ->method('get')
             ->with(BuildInterface::VAR_VERBOSE_COMMANDS)
             ->willReturn('-vvv');
-        $this->loggerMock->expects($this->once())
-            ->method('info')
-            ->with('Running DI compilation');
+        $this->loggerMock->expects($this->exactly(2))
+            ->method('notice')
+            ->withConsecutive(
+                ['Running DI compilation'],
+                ['End of running DI compilation']
+            );
         $this->shellMock->expects($this->once())
             ->method('execute')
             ->with('php ./bin/magento setup:di:compile -vvv --ansi --no-interaction');

diff --git a/src/Test/Unit/Process/Build/RefreshModulesTest.php b/src/Test/Unit/Process/Build/RefreshModulesTest.php
@@ -48,9 +48,12 @@ protected function setUp()
 
     public function testExecute()
     {
-        $this->loggerMock->expects($this->once())
-            ->method('info')
-            ->with('Reconciling installed modules with shared config.');
+        $this->loggerMock->expects($this->exactly(2))
+            ->method('notice')
+            ->withConsecutive(
+                ['Reconciling installed modules with shared config.'],
+                ['End of reconciling modules.']
+            );
         $this->configMock->expects($this->once())
             ->method('refresh');
 

diff --git a/src/Test/Unit/Process/ValidateConfigurationTest.php b/src/Test/Unit/Process/ValidateConfigurationTest.php
@@ -36,7 +36,7 @@ public function testExecuteWithoutValidators()
         );
 
         $this->loggerMock->expects($this->exactly(2))
-            ->method('info')
+            ->method('notice')
             ->withConsecutive(
                 ['Validating configuration'],
                 ['End of validation']
@@ -70,7 +70,7 @@ public function testExecuteWithCriticalError()
             ->method('validate');
 
         $this->loggerMock->expects($this->exactly(2))
-            ->method('info')
+            ->method('notice')
             ->withConsecutive(
                 ['Validating configuration'],
                 ['End of validation']
@@ -108,7 +108,7 @@ public function testExecuteWithWarningMessage()
             ->willReturn($warningResultMock);
 
         $this->loggerMock->expects($this->exactly(2))
-            ->method('info')
+            ->method('notice')
             ->withConsecutive(
                 ['Validating configuration'],
                 ['End of validation']
@@ -163,7 +163,7 @@ public function testExecuteWithWarningAndCriticalMessage()
             ->willReturn($this->createMock(Result\Success::class));
 
         $this->loggerMock->expects($this->exactly(2))
-            ->method('info')
+            ->method('notice')
             ->withConsecutive(
                 ['Validating configuration'],
                 ['End of validation']