Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAGECLOUD-3246: Add --use-rewrites option to install command, MAGECLOUD-2895: The var/log/install_upgrade.log is useless without dividers and timestamps #430

Merged
merged 4 commits into from
Mar 14, 2019

Conversation

BaDos
Copy link
Contributor

@BaDos BaDos commented Mar 11, 2019

Description

  • MAGECLOUD-3246: Added --use-rewrites option to install command
  • MAGECLOUD-2895: Added timestamps to the var/log/install_upgrade.log during upgrade/install of Magento

Fixed Issues (if relevant)

  1. https://magento2.atlassian.net/browse/MAGECLOUD-3246
  2. https://magento2.atlassian.net/browse/MAGECLOUD-2895

Manual testing scenarios

  1. Check that the file var/log/install_upgrade.log contains the installation date and the upgrading date.
  2. Check that after a new installation of Magento the admin URL does not contain index.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@andriyShevtsov
Copy link
Contributor

QA Passed

P.S. I propose to add names of both tasks into Title of PR

@BaDos BaDos changed the title MAGECLOUD-3246 and MAGECLOUD-2895 MAGECLOUD-3246: Add --use-rewrites option to install command, MAGECLOUD-2895: The var/log/install_upgrade.log is useless without dividers and timestamps Mar 14, 2019
@arhiopterecs arhiopterecs merged commit ca83af1 into magento:develop Mar 14, 2019
@ghost
Copy link

ghost commented Mar 14, 2019

Hi @BaDos, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept PR/issue status Release: 2002.0.17 ECE-Tools Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants