Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

magento/graphql-ce#948 - Move preference for ErrorHandlerInterface #949

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

vpodorozh
Copy link
Contributor

Description (#948)

app/etc/graphql/di.xml needs to be removed as well as graphql folder, preference should be added in the app/etc/di.xml file.

Areas are not supported on app level, lib/internal/Magento/Framework/App/Utility/Files.php in used for test only, so such tricks should be avoid.

Caused by #355

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento-engcom-team
Copy link
Contributor

Hi @novikor, thank you for the review.
ENGCOM-5922 has been created to process this Pull Request
✳️ @novikor, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-5922 has been created to process this Pull Request

@ghost
Copy link

ghost commented Sep 25, 2019

Hi @vpodorozh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@novikor novikor deleted the 2.3-develop#948 branch September 25, 2019 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants