Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unnecessary line code for command save to source. #2767

Merged
merged 2 commits into from
Jan 2, 2020
Merged

removed unnecessary line code for command save to source. #2767

merged 2 commits into from
Jan 2, 2020

Conversation

TadeuRodrigues
Copy link
Member

@TadeuRodrigues TadeuRodrigues commented Dec 27, 2019 •
edited
Loading

Description (*)

Removed unnecessary code line to source command save from repository

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Dec 27, 2019
@sidolov
Copy link
Contributor

sidolov commented Dec 31, 2019

Hi @TadeuRodrigues , please, sign CLA, otherwise, we can't process your pull request

@TadeuRodrigues
Copy link
Member Author

@sidolov done, thanks so much.

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jan 2, 2020
@sidolov
Copy link
Contributor

sidolov commented Jan 2, 2020

Test failures caused by unreliable DateTime usage and not related to PR changes. Should be fixed in scope of magento/magento2#26225

@sidolov sidolov added the Cleanup label Jan 2, 2020
@sidolov sidolov merged commit 5e86bce into 1.1-develop Jan 2, 2020
@sidolov sidolov deleted the removed_unnecessary_line_code branch January 2, 2020 11:07
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@sidolov sidolov

Labels
Cleanup
Projects
Pull Request Progress
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TadeuRodrigues @sidolov @magento-engcom-team