Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for Invalid date format in Functional and hotfix for failing Integration Tests #26225

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jan 1, 2020

Description (*)

All the Continuous Integration for Magento fails with Functional Tests.
This is fix for invalid date format.

Also delivering fix for Integration Tests fail when there's assertion the number of UNIONs that are based on years that are analyzed.

... and placing expected in the right place 🤦‍♂️

Fixed Issues (if relevant)

Functional Tests:
image

Integration Tests:
image

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 1, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Strix partners-contribution Pull Request is created by Magento Partner labels Jan 1, 2020
@lbajsarowicz lbajsarowicz changed the title Hotfix for (┛ಠ_ಠ)┛彡┻━┻ Invalid date format in Functional Tests Hotfix for Invalid date format in Functional Tests (┛ಠ_ಠ)┛彡┻━┻ Jan 1, 2020
@lbajsarowicz lbajsarowicz changed the title Hotfix for Invalid date format in Functional Tests (┛ಠ_ಠ)┛彡┻━┻ Hotfix for Invalid date format in Functional Tests Jan 1, 2020
@lbajsarowicz
Copy link
Contributor Author

The funny part - on December 31st tests failed also at:
image

@lbajsarowicz lbajsarowicz changed the title Hotfix for Invalid date format in Functional Tests Hotfix for Invalid date format in Functional and hotfix for failing Integration Tests Jan 2, 2020
@lbajsarowicz
Copy link
Contributor Author

OK. Now I'm rebasing the changes and need the review.

@rogyar rogyar self-assigned this Jan 2, 2020
@rogyar rogyar added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jan 2, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job (a cool issue though 🙃)

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6530 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants