-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for Invalid date format in Functional and hotfix for failing Integration Tests #26225
Hotfix for Invalid date format in Functional and hotfix for failing Integration Tests #26225
Conversation
Hi @lbajsarowicz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
3bbb50a
to
84b1310
Compare
OK. Now I'm rebasing the changes and need the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job (a cool issue though 🙃)
Hi @rogyar, thank you for the review. |
Notice: QA not applicable |
Hi @lbajsarowicz, thank you for your contribution! |
Description (*)
All the Continuous Integration for Magento fails with Functional Tests.
This is fix for invalid date format.
Also delivering fix for Integration Tests fail when there's assertion the number of UNIONs that are based on years that are analyzed.
... and placing
expected
in the right place 🤦♂️Fixed Issues (if relevant)
Functional Tests:
![image](https://user-images.githubusercontent.com/1639941/71647472-b72dd580-2cf7-11ea-9a54-319e66a898cc.png)
Integration Tests:
![image](https://user-images.githubusercontent.com/1639941/71647714-193c0a00-2cfb-11ea-8d4d-1df5954bbb46.png)
Manual testing scenarios (*)
N/A
Questions or comments
N/A
Contribution checklist (*)