Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ManageStockCondition.php #2768

Merged

Conversation

lbajsarowicz
Copy link
Contributor

Description (*)

I found that ManageStockCondition.php uses == for if() conditions, although the Interfaces provided : bool for is... methods. I replaced them, but then realised that } else { is really crappy there, so I also replaced the mechanics to quick return conditions.

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@lbajsarowicz
Copy link
Contributor Author

Checks are failing because of the date used in Functional and Integration tests. Fixed already in magento/magento2#26225

@m2-community-project m2-community-project bot moved this from Ready for Review to Reviewer Approved in Pull Request Progress Jan 3, 2020
@sidolov sidolov merged commit bed2d30 into magento:1.1-develop Jan 3, 2020
@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants