-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TLS Proxy Timeout #78
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiftedreality
approved these changes
Oct 16, 2019
bbatsche
approved these changes
Oct 16, 2019
oshmyheliuk
approved these changes
Oct 16, 2019
shiftedreality
added
Progress: testing in progress
and removed
Progress: review
PR/issue status
labels
Oct 16, 2019
Internal task: https://magento2.atlassian.net/browse/MAGECLOUD-4460 |
oshmyheliuk
approved these changes
Oct 16, 2019
@aepod Thank you for contribution. During internal testing we found out that correct way to set timeout is:
Without quotes and with s at the end. May you please change PR. |
This was fixed per Andrii's comment.
Changed per Andrii's comment.
QA approved |
shiftedreality
added
Progress: accept
PR/issue status
and removed
Progress: testing in progress
labels
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community
PR/issue origin
improvement
issue type
Partner: Zilker Technology
partners-contribution
Progress: accept
PR/issue status
Release: 1.0.0
Magento-Cloud-Docker Release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added timeout settings to the TLS and Varnish containers
Description
Added better defaults for timeouts on TLS and Docker.
Fixed Issues (if relevant)
Manual testing scenarios
Rebuild docker containers with these changes, timeouts are now 5 minutes. To test this you can use a very long running admin function, or a custom function that sleeps.
Contribution checklist