Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS Proxy Timeout #78

Merged
merged 5 commits into from
Oct 17, 2019
Merged

Fix TLS Proxy Timeout #78

merged 5 commits into from
Oct 17, 2019

Conversation

aepod
Copy link
Contributor

@aepod aepod commented Oct 15, 2019

Added timeout settings to the TLS and Varnish containers

Description

Added better defaults for timeouts on TLS and Docker.

Fixed Issues (if relevant)

  1. [Cloud Docker Core] TLS Proxy Times Out after 15 Seconds #35: [Cloud Docker Core] TLS Proxy Times Out after 15 Seconds

Manual testing scenarios

Rebuild docker containers with these changes, timeouts are now 5 minutes. To test this you can use a very long running admin function, or a custom function that sleeps.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@shiftedreality shiftedreality self-assigned this Oct 16, 2019
@shiftedreality shiftedreality changed the base branch from develop to 1.0 October 16, 2019 15:43
@shiftedreality shiftedreality added the Release: 1.0.0 Magento-Cloud-Docker Release label Oct 16, 2019
@shiftedreality
Copy link
Member

@andriyShevtsov
Copy link
Contributor

andriyShevtsov commented Oct 17, 2019

@aepod Thank you for contribution. During internal testing we found out that correct way to set timeout is:

    .first_byte_timeout = 300s;
    .between_bytes_timeout = 300s;

Without quotes and with s at the end. May you please change PR.

This was fixed per Andrii's comment.
Changed per Andrii's comment.
@andriyShevtsov
Copy link
Contributor

QA approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants