Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added sniff for deprecated model methods. #187 #189

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Added sniff for deprecated model methods. #187 #189

merged 6 commits into from
Aug 17, 2020

Conversation

milindsingh
Copy link
Member

Added sniff for #187 to discourage the use of Resource class from Model class.

Trigger Methods:

  • getResource()->load($object)
  • getResource()->save($object)
  • getResource()->delete($object)

Message: Possible use of the deprecated model method 'getResource()' to 'save' the data detected.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress May 23, 2020
@milindsingh milindsingh marked this pull request as ready for review May 23, 2020 18:42
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress May 26, 2020
lenaorobei
lenaorobei requested changes May 26, 2020
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address review comments.

@milindsingh
Copy link
Member Author

milindsingh commented Aug 17, 2020 •
edited

Thanks @ihor-sviziev
@lenaorobei I think its good to merge now.

Also, Is there any way to change labels to Partner: Born Group partners-contribution ?

ihor-sviziev
ihor-sviziev previously approved these changes Aug 17, 2020
View reviewed changes
@lenaorobei
Copy link
Contributor

Great! Thanks @ihor-sviziev. Let me run this test again Magento codebase and make sure it does not produce false positive findings.

@lenaorobei lenaorobei merged commit edca711 into magento:develop Aug 17, 2020
@m2-community-project m2-community-project bot moved this from Review in Progress to Done in Pull Request Progress Aug 17, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 21, 2022
@svera
Merge pull request #189 from magento-commerce/version-25
7be8305 
Bump to version 25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

Assignees

@ihor-sviziev ihor-sviziev

@lenaorobei lenaorobei

Labels
Community Insider: Cedcommerce community-insider-contribution Progress: done
Projects
Pull Request Progress
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@milindsingh @lenaorobei @ihor-sviziev @magento-engcom-team