Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update requirements to include php7.3 support #287

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Update requirements to include php7.3 support #287

merged 2 commits into from
Mar 25, 2019

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Dec 28, 2018

Description

Add support for php 7.3

  • add php 7.3 to .travis.yml
    • Initial successful build on travis - skips coverage check on 7.3 image due to lack of stable xdebug support.
  • update brainmaestro/composer-git-hooks to v2.6.1

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@pmclain
Update requirements to include php7.3 support
f98c8e2
@pmclain
Skip coverage check on php 7.3
9812c6b 
xdebug support for php 7.3 is in beta and not included in the travis image for
php 7.3.
@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Something Digital labels Dec 28, 2018
@magento-cicd2
Copy link

magento-cicd2 commented Dec 28, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 57.039% when pulling 9812c6b on pmclain:feature/php73 into a88548b on magento:develop.

@magento magento deleted a comment from coveralls Jan 10, 2019
@magento magento deleted a comment from coveralls Jan 10, 2019
@okolesnyk
Copy link
Member

okolesnyk commented Jan 14, 2019 •
edited
Loading

Hi @pmclain
Thank you for contribution! We really need this update.
Can I ask you please to create a PullRequest to PHP7.3-master brach?
We will use this branch to run all Magento Tests we have and verify that this version bump is not harmful.

Thank you

!!!! Update: !!!!
I cherry-picked your commits to PHP7.3-master, so no need to create separate PR.
Will update you on testing progress we have.

@pmclain
Copy link
Contributor Author

pmclain commented Jan 19, 2019

Hi @okolesnyk sorry for the delay, I must have missed the notification. Thanks for cherry-picking. Please let me know if anything else is required.

KevinBKozan
KevinBKozan reviewed Mar 15, 2019
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmclain I left two comments on this PR. MFTF compatibility with 7.3 looks good, and this update looks mostly good in terms of dependency compatibility with Magento.

bin/phpunit-checks
@@ -15,7 +15,9 @@ vendor/bin/phpunit --configuration dev/tests/phpunit.xml --testsuite unit --cove
echo "==============================="
echo " UNIT TEST COVERAGE"
echo "==============================="
vendor/bin/coverage-check clover.xml $UNIT_COVERAGE_THRESHOLD
if [[ ${TRAVIS_PHP_VERSION:0:3} != "7.3" ]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmclain I know it's been some time since this PR was created, but Xdebug 2.7.0 has since been released (with 7.3 support).
At this point, is this conditional skip still necessary?

composer.lock
@@ -4,7 +4,7 @@
"Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
"This file is @generated automatically"
],
"content-hash": "ab52f12570440f5833f0d81bce06f884",
"content-hash": "0a58509a75dc4ea99a4bef3d13ee4075",
Copy link
Contributor

@KevinBKozan KevinBKozan Mar 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A heads up, composer.json and .lock has changed since this was originally created, the merge is pretty ugly.
You may be better off taking your current lock file and running a simple composer update allure-framework/allure-codeception after resolving composer.json conflicts.

@KevinBKozan KevinBKozan mentioned this pull request Mar 25, 2019
Merged
5 tasks
@KevinBKozan KevinBKozan merged commit 9812c6b into magento:develop Mar 25, 2019
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 22, 2023
@okolesnyk
Merge pull request #287 from magento-commerce/4.2.1-develop
26db895 
Update MFTF to solve the issue with php-webdriver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan left review comments

Assignees
No one assigned
Labels
Partner: Something Digital partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pmclain @magento-cicd2 @coveralls @okolesnyk @KevinBKozan @magento-engcom-team