Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide possibility to customize analyzer/tokenyzer for Elasticsearch #18

Open
vkublytskyi opened this issue Jun 6, 2018 · 1 comment
Open

Provide possibility to customize analyzer/tokenyzer for Elasticsearch #18

vkublytskyi opened this issue Jun 6, 2018 · 1 comment
Assignees
@HirokazuNishi
Labels
core Should be implemented as contribution to Magento 2 core postponed Tasks involve Magento core modification and should be done after MVP implementation Progress: dev in progress
Projects
Backlog
Milestone
Magento Core Impr...

Comments

@vkublytskyi
Copy link

Magento 2 has hardcoded Elasticsearch analyzer/tokenyzer. Existing implementation should be extended to provide a possibility to change analyzer/tokenyzer. At primitive implementation, it may be argument passed by DI. Also possible implementation is to provide possibility to choose analyzer/tokenyze from admin config panel per store view. More suitable solution will be to pick correct analyzer/tokenyzer based on store locale and provide possibility to other modules register their implementation of choosing valid analyzer/tokenyzer.

Any of listed solution is valid and it is up to developer which path to follow.
@vkublytskyi vkublytskyi added the core Should be implemented as contribution to Magento 2 core label Jun 6, 2018
@vkublytskyi vkublytskyi mentioned this issue Jun 6, 2018
Open
@HirokazuNishi HirokazuNishi self-assigned this Jun 8, 2018
@HirokazuNishi
Copy link
Collaborator

Development branch is here:
https://github.com/Veriteworks/magento2-l10n/tree/improve-elasticsearch

@vkublytskyi vkublytskyi mentioned this issue Aug 7, 2018
Closed
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 7, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
b1fa6d7 
…yzer/tokenyzer for Elasticsearch

 - reworked ElasticSearch Configuration interfaces for better backward compatibility support
 - extended flexibility of XML configuration
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 9, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
666e69a 
…yzer/tokenyzer for Elasticsearch

 - Fixed missed standard filters list declared in esconfig.xml
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 9, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
754195c 
…yzer/tokenyzer for Elasticsearch

 - Soften requirements to allow partial schema declaration for overriding
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 9, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
99cc27d 
…yzer/tokenyzer for Elasticsearch

 - Fixed char filters declared in esconfig.xml file
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 9, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
4ab16d2 
…yzer/tokenyzer for Elasticsearch

 - Integration test to cover index configuration build
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 9, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
9281554 
…yzer/tokenyzer for Elasticsearch

 - Fixed unit test for index settings builder
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 9, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
8072b77 
…yzer/tokenyzer for Elasticsearch

 - Fixed code style and minor issues to green static tests
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 10, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
1430ce0 
…yzer/tokenyzer for Elasticsearch

 - Fixed code style and minor issues to green static tests
vkublytskyi pushed a commit to Veriteworks/magento2-l10n that referenced this issue Aug 10, 2018
magento/magento2-jp/issues/18 : Provide possibility to customize anal…
2b5a50f 
…yzer/tokenyzer for Elasticsearch

 - Fixed code style and minor issues to green static tests
@vkublytskyi vkublytskyi added the postponed Tasks involve Magento core modification and should be done after MVP implementation label Nov 15, 2018
@vkublytskyi vkublytskyi added this to the Magento Core Improvements milestone Nov 15, 2018
@okorshenko okorshenko added this to Ready for Grooming in Backlog Mar 9, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Dev In Progress in Backlog Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HirokazuNishi HirokazuNishi

Labels
core Should be implemented as contribution to Magento 2 core postponed Tasks involve Magento core modification and should be done after MVP implementation Progress: dev in progress
Projects
Backlog
  
Dev In Progress
Milestone
Magento Core Improvements
Development

No branches or pull requests
2 participants
@HirokazuNishi @vkublytskyi