Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MFTF] Final set of changes to improve the MFTF tests #369

Closed
wants to merge 6 commits into from
Closed

[MFTF] Final set of changes to improve the MFTF tests #369

wants to merge 6 commits into from

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Jan 28, 2020

Description (*)

This PR contains all other changes I introduced to MFTF and some more:

  • Unified stepKey to be camelCase (lower first)
  • Added ActionGroup suffix to all Action Groups
  • Updated documentation to follow best practices

Fixed Issues (if relevant)

  1. [ MFTF ] Mess in ActionGroups: invalid names, multiple nodes. magento2#26331

Manual testing scenarios (*)

Run MFTF tests for:

Related Pull Requests

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

…f-changes

# Conflicts:
#	app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/OptionsMenuActionGroup.xml
#	app/code/Magento/PageBuilder/Test/Mftf/ActionGroup/WYSIWYGActionGroup.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderBlockTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderColumnTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderDividerTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHeadingTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderHtmlTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderImageTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderProductsCommonTests.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderRowTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabGroupTests.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTabItemConfigurationTests.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderTextTest.xml
#	app/code/Magento/PageBuilder/Test/Mftf/Test/AdminPageBuilderVideoTest.xml
@lbajsarowicz
Copy link
Contributor Author

We won't be able to do it in one PR.
Before things get merged, we have hundreds of conflicts :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants