Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Video) Calling jarallax-wrapper and loading on demand librairies #865

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Amadeco
Copy link

@Amadeco Amadeco commented Feb 18, 2024

I needed to replace jarallax with jarallax-wrapper to make it work with a custom Js bundler (Magepack Bundle) Indeed, without jarallax-wrapper, window.jarallax is not populated and return an error (undefined var).

I take advantage of this commit to suggest to load on demand librairies.

I needed to replace jarallax with jarallax-wrapper to make it work with a custom Js bundler  (Magepack Bundle)
Indeed, without  jarallax-wrapper, window.jarallax is not populated and return an error (undefined var).

I take advantage to this commit to suggest to load on demand librairies (jarallaxVideo, vimeoWrapper) after the check of the data background-type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant