Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#184 Setup Code Style Checks 📦 #188

Merged
merged 46 commits into from
Apr 30, 2020
Merged

#184 Setup Code Style Checks 📦 #188

merged 46 commits into from
Apr 30, 2020

Commits on Apr 20, 2020

  1. #184 📦 Added static code checkers to the project

    Roman Glushko committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    49f954f View commit details
    Browse the repository at this point in the history

  2. #184 Updated stylecheck config file (using Google Java standards with… 

    … 4 space config)
    Roman Glushko committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    69205e6 View commit details
    Browse the repository at this point in the history

  3. Added static code checks to CI/CD

    @roma-glushko
    roma-glushko committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    29d6760 View commit details
    Browse the repository at this point in the history

  4. #184 Specified checkstyle version to install

    Roman Glushko committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    e1cab0d View commit details
    Browse the repository at this point in the history

  5. #184 Made checkstyles check failed on warnings

    Roman Glushko committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    209500b View commit details
    Browse the repository at this point in the history

  6. #184 Made checkstyles check failed on warnings

    Roman Glushko committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    773a37a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2020

  1. Merge branch '1.0.1-develop' into 184-setup-code-style-checks

    Vitaliy committed Apr 21, 2020
    Configuration menu
    Copy the full SHA
    df44311 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2020

  1. #184 Tried checkstyle IDE plugin to autofix code style issues

    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    5a70e68 View commit details
    Browse the repository at this point in the history

  2. #184 Inited static checks on PR level

    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    2f13a5e View commit details
    Browse the repository at this point in the history

  3. #184 Running code reformatting on the actions package

    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    3dc4ecc View commit details
    Browse the repository at this point in the history

  4. Revert "#184 Running code reformatting on the actions package" 

    This reverts commit 3dc4ecc.
    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    e02c40b View commit details
    Browse the repository at this point in the history

  5. Revert "#184 Tried checkstyle IDE plugin to autofix code style issues" 

    This reverts commit 5a70e68.
    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    eea4c47 View commit details
    Browse the repository at this point in the history

  6. Merge branch '1.0.1-develop' of https://github.com/magento/magento2-p… 

    …hpstorm-plugin into 184-setup-code-style-checks

# Conflicts:
#	build.gradle
    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    6a4fd99 View commit details
    Browse the repository at this point in the history

  7. #184 Enabled partial checkstyle checks

    Roman Glushko committed Apr 24, 2020
    Configuration menu
    Copy the full SHA
    87ad45d View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2020

  1. #184 Changed an env variable from where PR target branch comes

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    ea0fb85 View commit details
    Browse the repository at this point in the history

  2. #184 Updated env variables for PR data

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    c1240e0 View commit details
    Browse the repository at this point in the history

  3. Merge branch '1.0.1-develop' of https://github.com/magento/magento2-p… 

    …hpstorm-plugin into 184-setup-code-style-checks
    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    d551f5e View commit details
    Browse the repository at this point in the history

  4. #184 Added logging of information

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    04fd676 View commit details
    Browse the repository at this point in the history

  5. #184 Changed names of PR envs

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6d59733 View commit details
    Browse the repository at this point in the history

  6. #184 Tried to enable debug mode

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    23ad598 View commit details
    Browse the repository at this point in the history

  7. #184 Tried to pass PR information via additional step in the job flow

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    e529bc0 View commit details
    Browse the repository at this point in the history

  8. #184 Changed env var names

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    9cfbb20 View commit details
    Browse the repository at this point in the history

  9. #184 Provided a separate env vars for each checkstyle task

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    7ead0fb View commit details
    Browse the repository at this point in the history

  10. #184 Output additional information via println

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    0add624 View commit details
    Browse the repository at this point in the history

  11. #184 Collect changed file information

    Roman Glushko committed Apr 28, 2020
    Configuration menu
    Copy the full SHA
    6b7671e View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2020

  1. #184 Fixed issue with unknown method

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    0cb3040 View commit details
    Browse the repository at this point in the history

  2. #184 Pulling the base branch before doing static checks

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    b35818d View commit details
    Browse the repository at this point in the history

  3. #184 Checking another way of getting PR changelog - via an external g… 

    …ithub action
    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    09546cb View commit details
    Browse the repository at this point in the history

  4. #184 Adjusted usage of trilom/file-changes-action

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    e48af63 View commit details
    Browse the repository at this point in the history

  5. #184 Cleaned up getting PR changelog

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    bfdd8d8 View commit details
    Browse the repository at this point in the history

  6. #184 Handled empty changelog case

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    6b16e74 View commit details
    Browse the repository at this point in the history

  7. #184 Made pmd and stopbugs process PR changelog

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    9fb2fa2 View commit details
    Browse the repository at this point in the history

  8. #184 Autofix the component

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    4052650 View commit details
    Browse the repository at this point in the history

  9. #184 Removed compileJava task

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    255d0f0 View commit details
    Browse the repository at this point in the history

  10. #184 Fixing checkstyle violations

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    27aea9b View commit details
    Browse the repository at this point in the history

  11. #184 Fixed checkstyle issues

    Roman Glushko committed Apr 29, 2020
    Configuration menu
    Copy the full SHA
    ae2efce View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2020

  1. #184 Kept running code static checks on the linux environment only

    Roman Glushko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    452e4e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch '1.0.1-develop' of https://github.com/magento/magento2-p… 

    …hpstorm-plugin into 184-setup-code-style-checks
    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    83822f4 View commit details
    Browse the repository at this point in the history

  3. Fixed PMD rules

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    f515234 View commit details
    Browse the repository at this point in the history

  4. Fixed staticChecks.gradle

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    8e8b711 View commit details
    Browse the repository at this point in the history

  5. Fixed checkstyle

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    f536a2c View commit details
    Browse the repository at this point in the history

  6. Fixed checkstyle 2

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    52b614e View commit details
    Browse the repository at this point in the history

  7. Removed unused style, fixed form

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    22238e7 View commit details
    Browse the repository at this point in the history

  8. Added env var to spot bugs

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    fa0e71b View commit details
    Browse the repository at this point in the history

  9. Removed spot bugs

    Vitaliy Boyko committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    3c37758 View commit details
    Browse the repository at this point in the history

  10. Merge branch '1.0.1-develop' into 184-setup-code-style-checks

    Vitaliy committed Apr 30, 2020
    Configuration menu
    Copy the full SHA
    e46d107 View commit details
    Browse the repository at this point in the history