#30: Completion. Remove PHP completions from all not appropriate places in XML files #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
moved this from Ready for Review
to Review in Progress
in Pull Request Progress
VitaliyBoyko
requested changes
Apr 2, 2020
VitaliyBoyko
requested changes
Apr 2, 2020
|
|
||
| /* File Path Completion provider */ | ||
| extend(CompletionType.BASIC, psiElement(XmlTokenType.XML_ATTRIBUTE_VALUE_TOKEN) | ||
| .inside(XmlPatterns.xmlAttribute().withName("template")), |
There was a problem hiding this comment.
Hi.
I've refactored most of the string literals to constant classes. Please do the same way.
Thank you!
There was a problem hiding this comment.
We are storing all magento related string literals under com/magento/idea/magento2plugin/magento.
There was a problem hiding this comment.
🤞 I'm about the new changes.
There was a problem hiding this comment.
Okay, I will make sure of these changes
VitaliyBoyko
moved this from Review in Progress
to Changes Requested
in Pull Request Progress
m2-community-project
bot
added
Progress: changes requested
and removed
Progress: review
labels
|
I see other issues, however, let's fix them in the scope of a separate task. |
VitaliyBoyko
approved these changes
Apr 2, 2020
m2-community-project
bot
moved this from Changes Requested
to Done
in Pull Request Progress
m2-community-project
bot
removed
Progress: changes requested
Progress: needs update
labels
|
This PR includes reward labels for #62. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR will fix the PHP class and module name completion from inappropriate places
Fixed Issues (if relevant)
Contribution checklist (*)