The deployer tool does not handle symlinks correctly, fails silently.

[andrewhowdencom]

Preconditions

1. 2.1.7
2. php7.0

Steps to reproduce

1. Clone an existing site, having previously been installed and committed to vcs, but without the vendored dependencies.
2. rm -rf media, and create a symlink that points to /tmp/thisdoesnotexist
3. Try and install the application

Expected result

1. The application install fails critically

Actual result

1. The application install appears to succeed, but the files boostrap.php etc. are missing.

See the following stack overflow post for further details. https://magento.stackexchange.com/questions/177924/magenta-2-1-5-composer-install-fails-to-generate-all-files/184666#184666

[magento-engcom-team]

@andrewhowdencom, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. Please provide more detailed steps to reproduce.

[andrewhowdencom]

Edit: I have removed my initial and unfair reply. I'm sorry for it's venom.

To assist me in helping you debug this, can you please articulate the steps you took to correct the issue? In particular, I have noted the problem in some detail here:

https://magento.stackexchange.com/questions/177924/magento-2-1-5-composer-install-fails-to-generate-all-files/184666#184666?

Can you reiterate the steps that you followed in line with the above article?

[ghost]

@andrewhowdencom, we were not able to reproduce this issue by following the steps you provided. Please provide more detailed steps to reproduce.

[andrewhowdencom]

Hola @engcom-backlog-pb this is a particularly expensive issue to debug, and I don't have any reason to do it at the minute. Can you clarify the exact steps that you attempted, as asked before?

Cheers,

[ghost]

@andrewhowdencom

1. Clone magento 2 from repository.
2. cd pub
3. rm -rf media
4. ln -s /tmp/thisdoesnotexist/media
5. Install the application

[andrewhowdencom]

Install the application

By this I guess you mean composer install?

[ghost]

@andrewhowdencom
No, install through command line.

[andrewhowdencom]

The issue is specific to the composer installer; by install i mean composer install. See the references:

https://github.com/magento/magento-composer-installer/blob/master/src/MagentoHackathon/Composer/Magento/DeployManager.php#L97

https://github.com/magento/magento-composer-installer/blob/master/src/MagentoHackathon/Composer/Magento/Deploystrategy/Copy.php#L35

(And the above stack overflow topic)

[ghost]

Try and install the application

by install i mean composer install

@andrewhowdencom, please provide obvious Steps to Reproduce.

[andrewhowdencom]

Hi @engcom-backlog-pb;

I don't work on any Magneto 2 stuff at the minute, so will not go through the process of exhaustively documenting this. However, broadly it's:

1. Install Magento as specified in https://devdocs.magento.com/guides/v2.3/install-gde/composer.html

Normally you'd commit this and save it somewhere as the basis of a new site, but not required for this issue.

2. Delete everything that's git ignore. vendor, stuff in web etc.
3. rm -rf and symlink pub/media to /tmp/thisdoesnotexist. This pattern is pretty common for installing applications without downtime; see Capistrano
4. composer install again. Here is the silent failure. You'll find that not all files are correctly duplicated out of the vendor/ tree into the application root.

Using composer install -vvv also shows the issue, but it doesn't exit nonzero so the installation is a "success"

I'll pass this issue onto others who it might affect, see if they're interested in following it up further.

[ghost]

Hello @andrewhowdencom

Install Magento as specified in https://devdocs.magento.com/guides/v2.3/install-gde/composer.html

Do I need to install or only create-project?

Delete everything that's git ignore. vendor, stuff in web etc.

When we are installing Magento using Composer, git is not used.

duplicated out of the vendor/ tree into the application root.

As I know, code is never duplicated or copied from vendor/ to app/code/ dir.

I have tried many to replicate this issue in many different ways, but only
Missing write permissions to the following paths: /var/www/html/magento-composer/pub/media
exception happens.

[andrewhowdencom]

Do I need to install or only create-project?

I think create-project does the initial installation

Delete everything that's git ignore. vendor, stuff in web etc.

Yes, I understand it doesn't imply it -- but usually whenever I start a project, the first thing I do is commit it to version control. It's like:

1. composer create-project
2. git init .
3. git add .
4. git commit -m "Initial Commit"
5. git push foo/bar

Then, in a new dir,

1. git clone foo/bar
2. ln -s media /tmp/nonexist
3. composer install

In that case, everything in .gitignore in the composer projects will not be present, by virtue of cloning the repository from upstream again.

It's in this case it should fail.

[ghost]

@andrewhowdencom
Now Steps to Reproduce seems to be clear, but I cannot reproduce this issue.
I've tested on 2.1.7 and 2.2.5.

[ghost]

@andrewhowdencom, we are closing this issue due to inactivity. If you'd like to update it, please reopen the issue.

[ghost]

Hi @hostep, do we need to open this issue in magento-composer-installer repo ? as this not related to this github repo codebase ?

[hostep]

@engcom-backlog-nazar: unfortunately issue reporting was disabled on https://github.com/magento/magento-composer-installer, only PR's are allowed there.
I think we can keep it over here.

[ghost]

@hostep ok, i was not seeing that there are no issue tab . 👍

[magento-engcom-team]

✅ Confirmed by @engcom-backlog-nazar
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99260, MAGETWO-99261 were created

Issue Available: @engcom-backlog-nazar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.