Handle lifetime value 0 for form_key cookie #10528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 should not be interpreted as a duration.
magento-team
pushed a commit
that referenced
this pull request
Aug 16, 2017
magento-team
pushed a commit
that referenced
this pull request
Aug 16, 2017
[EngCom] Public Pull Requests - MAGETWO-71578: Magento\Test\Js\LiveCodeTest is failing because of reference to missing file in blacklist #10536 - MAGETWO-71544: Handle lifetime value 0 for form_key cookie #10528 - MAGETWO-71542: Show shipping methods in shipping estimator as loading during estimation #10514
magento-team
pushed a commit
that referenced
this pull request
Oct 6, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 should not be interpreted as a duration but so that the cookie lasts until session closes.
Description
Leave out the duration if lifetime is set to 0. This results in the cookie to last until the session closes.
Fixed Issues
Manual testing scenarios
See steps to reproduce in #10527