Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2.0-RC2.2] Static content deploy 'quick' strategy acts like 'standard' strategy #10674

Open
hostep opened this issue Aug 26, 2017 · 21 comments
Labels
Area: Admin UI Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@hostep
Copy link
Contributor

hostep commented Aug 26, 2017

Preconditions

Steps to reproduce

  1. Install Magento 2.2.0-rc22 or 2.2.7 or 2.3.0 or 2.4.3 or 2.4-develop using composer
  2. Add 2 language packs using composer: composer require honl/magento2-nl-nl imaginaerum/magento2-language-fr-fr
  3. Run bin/magento setup:upgrade
  4. Create 2 different storeviews in the backend and set the Locale configuration to Dutch (Netherlands) and French (France) for those 2 storeviews
  5. Reindex & flush the caches
  6. Run: rm -R var/view_preprocessed/* pub/static/* (so we start from a clean slate)
  7. Run: php bin/magento setup:static-content:deploy -s standard -f -t Magento/luma nl_NL fr_FR
  8. Results:
Deploy using standard strategy
frontend/Magento/blank/nl_NL            2083/2083           ============================ 100% %  24 secs
frontend/Magento/blank/fr_FR            2083/2083           ============================ 100% %  26 secs
frontend/Magento/luma/nl_NL             2098/2098           ============================ 100% %  29 secs
frontend/Magento/luma/fr_FR             2098/2098           ============================ 100% %  29 secs

Execution time: 114.57253885269165
  1. Run: rm -R var/view_preprocessed/* pub/static/* (so we start from a clean slate)
  2. Run: php bin/magento setup:static-content:deploy -s quick -f -t Magento/luma nl_NL fr_FR
  3. Results:
Deploy using quick strategy
frontend/Magento/blank/nl_NL            2083/2083           ============================ 100% %  25 secs
frontend/Magento/blank/fr_FR            2083/2083           ============================ 100% %  26 secs
frontend/Magento/luma/nl_NL             2098/2098           ============================ 100% %  31 secs
frontend/Magento/luma/fr_FR             2098/2098           ============================ 100% %  31 secs

Execution time: 119.81762409210205

Expected result

  1. As advertised in the devdocs, the quick strategy should run a lot faster then the standard strategy when using multiple locale's

Actual result

  1. Quick strategy behaves the same as standard strategy
@misha-kotov
Copy link

Thanks for reporting, internal issue is MAGETWO-72300

@misha-kotov misha-kotov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 5, 2017
@magento-engcom-team magento-engcom-team added 2.2.0-rc2 Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Area: Frontend Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Oct 11, 2017
@TomashKhamlai TomashKhamlai self-assigned this Dec 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @TomashKhamlai. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Nov 2, 2021
@engcom-Hotel engcom-Hotel removed their assignment Jan 21, 2022
@hostep
Copy link
Contributor Author

hostep commented Feb 17, 2022

@engcom-Alfa: why exactly did you remove the "Confirmed" label again, and why did @engcom-Hotel remove their assignment?

I'm afraid that this ticket will now end up in a state that it will no longer be processed in the future ...

@engcom-Delta engcom-Delta self-assigned this Mar 1, 2022
@m2-assistant
Copy link

m2-assistant bot commented Mar 1, 2022

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Mar 3, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 3, 2022
@engcom-Delta
Copy link
Contributor

Hi @hostep ,
The issue is reproducible with the given steps on Magento 2.4 Develop. Hence Marking the issue 'Issue Confirmed'.

Steps followed:

  1. Install Magento 2.2.0-rc22 or 2.2.7 or 2.3.0 or 2.4.3 or 2.4-develop using composer
  2. Add 2 language packs using composer: composer require honl/magento2-nl-nl imaginaerum/magento2-language-fr-fr
  3. Run bin/magento setup:upgrade
  4. Create 2 different storeviews in the backend and set the Locale configuration to Dutch (Netherlands) and French (France) for those 2 storeviews
  5. Reindex & flush the caches
  6. Run: rm -R var/view_preprocessed/* pub/static/* (so we start from a clean slate)
  7. Run: php bin/magento setup:static-content:deploy -s standard -f -t Magento/luma nl_NL fr_FR

Results:
Screenshot from 2022-03-01 14-46-48

@github-jira-sync-bot
Copy link

❌ Something went wrong. Cannot create Jira issue.

@hostep
Copy link
Contributor Author

hostep commented Mar 3, 2022

Thanks, it's great to see that the majority of time spend on this issue in the last 5 years, was trying to reproduce it instead of trying to fix it.

@engcom-Delta engcom-Delta added Area: Admin UI and removed Area: Frontend Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 3, 2022
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Mar 3, 2022
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Mar 3, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 3, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 3, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2551 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Mar 3, 2022

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Mar 10, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Component: Setup Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Ready for Development
Development

No branches or pull requests