Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong tax is displayed in checkout for Virtual products #17425

Open
navarr opened this issue Aug 7, 2018 · 13 comments · May be fixed by #33249
Open

Wrong tax is displayed in checkout for Virtual products #17425

navarr opened this issue Aug 7, 2018 · 13 comments · May be fixed by #33249
Assignees
Labels
Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@navarr
Copy link
Member

navarr commented Aug 7, 2018

Under certain scenarios the tax displayed in checkout for a virtual product does not match the address selected by the billing method

Preconditions

  1. Magento 2.2.6-dev installed
    -- Updated(09/19/2019): Still actual on 2.3-develop
    -- Updated(02/15/2021): Modified for similar issue on 2.4-develop
  2. Default Tax rates configured (typical of a clean installation)
  3. Addition of a Tax Rule that enables those rates
    virtual-product-setup
  4. A virtual product created with price point $10

Steps to reproduce

  1. Create a customer account
  2. Create a default billing & shipping address in New York, such as:
    123 Main St
    Flushing, NY 11354
  3. Save
  4. Browse to category to add Virtual product to cart
  5. Proceed to checkout
  6. Note sales tax of $0.84
  7. Click "Edit" under the billing address
  8. Click "Update"
  9. Press back till you are no longer in checkout
  10. Go to customer account page
  11. Edit Address, set it to an address in California such as:
    1 Main St
    San Jose, CA 95131
  12. Save
  13. Click Mini-cart and click "Proceed to Checkout"

Video Recreation

Expected result

  1. Sales tax of $0.83 (calculated off California address)

Actual result

  1. Sales tax of $0.84 (calculated off New York address)

Notice

  • Clicking a payment method in the checkout will show the California address as the selected address, despite showing the New York tax)
  • After observing the results, if you go back to the cart and click "Update Cart" and then proceed to checkout, the correct sales tax will be displayed
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Aug 7, 2018

Hi @navarr. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me {$VERSION} instance

where {$VERSION} is version tags (starting from 2.2.0+) or develop branches (2.2-develop +).
For more details, please, review the Magento Contributor Assistant documentation.

@navarr do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 7, 2018
@navarr
Copy link
Member Author

navarr commented Aug 7, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @navarr. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @navarr, here is your Magento instance.
Admin access: https://i-17425-2-2-develop.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost self-assigned this Aug 8, 2018
@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Component: Tax labels Aug 8, 2018
@ghost
Copy link

ghost commented Aug 8, 2018

@navarr , thank you for your report.
We've acknowledged the issue and added to our backlog.

@ghost ghost removed their assignment Aug 8, 2018
@magento-engcom-team magento-engcom-team added this to Ready for Dev in Community Backlog Mar 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 3, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@ghost ghost removed this from Ready for Dev in Community Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Development in Low Priority Backlog Oct 20, 2020
@ghost ghost removed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Oct 20, 2020
@magento-engcom-team magento-engcom-team added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Nov 30, 2020
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Nov 30, 2020
@stale
Copy link

stale bot commented Feb 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Feb 15, 2021
@navarr
Copy link
Member Author

navarr commented Feb 15, 2021

@magento-engcom-team give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @navarr. Thank you for your request. I'm working on Magento instance for you.

@stale stale bot removed the stale issue label Feb 15, 2021
@magento-deployment-service
Copy link

@navarr
Copy link
Member Author

navarr commented Feb 15, 2021

I've updated the issue with slightly different recreation steps for 2.4; as the original issue was fixed

@stale
Copy link

stale bot commented May 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label May 2, 2021
@navarr
Copy link
Member Author

navarr commented May 3, 2021

There hasn't been a non-patch release since the last time I confirmed this issue. I don't believe it's qualified to be stale yet

@stale stale bot removed the stale issue label May 3, 2021
@Den4ik
Copy link
Contributor

Den4ik commented May 3, 2021

@magento I'm working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tax Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Pull Request In Progress
4 participants