Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password strength indicator shows "No Password" even when a password is entered #19071

Closed
cSkip opened this issue Nov 5, 2018 · 15 comments
Closed
Assignees
Labels
Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@cSkip
Copy link

cSkip commented Nov 5, 2018

The password strength indicator shows "No Password" at times when there is a password entered.

Preconditions (*)

  1. Anywhere where the password strength indicator is being used.

  2. Customer password settings:

screen shot 2018-11-05 at 2 58 51 pm

Passwords that are too guessable or risky will return a 0 zxcvbnScore see Here. e.g when "password" is entered as the actual password.

Steps to reproduce (*)

  1. At the account register page, type "password" in the password field.

Expected result (*)

  1. An expected result would likely be a Weak Password message.

Actual result (*)

screen shot 2018-11-05 at 11 46 08 am

  1. the message with display "No Password".

In this scenario the issue is that the javascript is not handling a return value of "0" from xcsvbn(password) differently than an empty password.

I am currently running Magento v2.2.5

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @cSkip. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@cSkip do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@dimasalamatov dimasalamatov self-assigned this Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@dimasalamatov
Copy link
Contributor

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov, here is your Magento instance.
Admin access: http://34.228.235.121/i-19071-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@dimasalamatov
Copy link
Contributor

@magento-engcom-team give me 2.2.5 instance

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov. Thank you for your request. I'm working on Magento 2.2.5 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov, here is your Magento instance.
Admin access: http://34.228.235.121/i-19071-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@cSkip
Copy link
Author

cSkip commented Nov 5, 2018

Sorry, I forgot to add the current Customer password configuration that was used.

@dimasalamatov
Copy link
Contributor

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dimasalamatov, here is your Magento instance.
Admin access: http://34.228.235.121/i-19071-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@dimasalamatov dimasalamatov added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 5, 2018
@swnsma swnsma added Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 16, 2018
@magento-engcom-team
Copy link
Contributor

@swnsma Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96390, MAGETWO-96391 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 16, 2018
@swnsma
Copy link
Contributor

swnsma commented Nov 16, 2018

Fixed with PRs:
2.2-develop: #19073
2.3-develop: #19087

@swnsma swnsma added Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Nov 19, 2018
@swnsma swnsma closed this as completed Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

4 participants