Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login user programmatically showing wrong default header message "Default welcome msg!" instead of showing "Welcome, user!" #19214

Closed
kalpeshhiran opened this issue Nov 14, 2018 · 5 comments
Assignees
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue

Comments

@kalpeshhiran
Copy link

Description

When you login to Magento 2.2.6 programmatically with code below, header show default message "Default welcome msg!" instead of "Welcome, user!"

// Load customer session
$customerSession = $objectManager->create('Magento\Customer\Model\Session');
$customerSession->setCustomerAsLoggedIn($customer);

Preconditions

  1. Magento 2.2.6

Steps to reproduce

  1. Login with setCustomerAsLoggedIn function
  2. Even after session is created, header shows "Default welcome msg!" instead of "Welcome, user!"

Expected result

  1. Session should get started
  2. Header should show "Welcome, user!"

Actual result

  1. Session getting started
  2. Header shows "Default welcome msg!"
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Nov 14, 2018
@magento-engcom-team
Copy link
Contributor

Hi @kalpeshhiran. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@kalpeshhiran do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@orlangur orlangur self-assigned this Nov 15, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@orlangur
Copy link
Contributor

orlangur commented Nov 15, 2018

@kalpeshhiran, GitHub is intended for bug reports, please use Magento Stack Exchange for questions on how particular customization can be implemented.

Note that welcome message is displayed using https://devdocs.magento.com/guides/v2.2/extension-dev-guide/cache/page-caching/private-content.html, so, after login corresponding section needs to be invalidated.

@kalpeshhiran
Copy link
Author

@orlangur I assume this is a bug and I am not asking for any customization.

When someone login to Magento 2.2.6 either with login form or login function provided by Magento setCustomerAsLoggedIn, behaviour should be same.

I am looking to see just default msg which is shown after user login (includes fullname), and not really looking to customize anything.

I will appreciate if anyone can help with that.

@orlangur
Copy link
Contributor

When someone login to Magento 2.2.6 either with login form or login function provided by Magento setCustomerAsLoggedIn, behaviour should be same.

@kalpeshhiran no, please check the documentation I referenced. I suppose in the latter case private data section is not invalidated properly thus you see old data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed non-issue
Projects
None yet
Development

No branches or pull requests

3 participants