Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to create partial invoice from Magento2 REST API for Pay on account [Credit limit] payment method orders #22300

Closed
i95devdivya opened this issue Apr 12, 2019 · 6 comments
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed

Comments

@i95devdivya
Copy link

Preconditions

  1. Magento EE 2.2.6 B2B
  2. PHP 7.0.14

Steps to reproduce

  1. Create order in Magento either with company user or company admin with Pay on account(Company Credit) payment method with multiple items with different quantities or single item with more than one quantity
  2. Try to create invoice for the order for the partial quantity from Magento REST API using service POST /V1/order/{orderId}/invoice

Expected result

  1. Getting error like “Invoice Document Validation Error(s): An invoice for partial quantities cannot be issued for this order. To continue, change the specified quantity to the full quantity.”

Actual result

  1. Invoice should be created with the partial quantity

Note

  1. We are able to create partial from Magento2 admin order view page
@m2-assistant
Copy link

m2-assistant bot commented Apr 12, 2019

Hi @i95devdivya. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@i95devdivya do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 12, 2019
@i95devdivya
Copy link
Author

i95devdivya commented Apr 12, 2019

We observed the following plug-in from B2B Company Credit module causing the issue

"Magento\CompanyCredit\Plugin\Sales\Model\Order\InvoiceQuantityValidatorPlugin"

If we comment above plug-in from di.xml then we are able to create partial invoice from REST API.

@ghost ghost self-assigned this Apr 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @engcom-backlog-nazar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost
Copy link

ghost commented Apr 15, 2019

Hi @i95devdivya thank you for you report, this issue has already fixed in 2.3-develop branch and 2.2-develop branch and available on 2.2.8 release and 2.3.1 release.

@ghost ghost closed this as completed Apr 15, 2019
@i95devdivya
Copy link
Author

@engcom-backlog-nazar
Is there any patch is available for EE 2.2.6?

@i95devdivya
Copy link
Author

We are facing the same issue in Magento Commerce B2B 2.3.5.

The same plug-in which I have mentioned earlier from B2B Company Credit module causing the issue

"Magento\CompanyCredit\Plugin\Sales\Model\Order\InvoiceQuantityValidatorPlugin"

If we comment above plug-in from di.xml then we are able to create partial invoice from REST API.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed
Projects
None yet
Development

No branches or pull requests

2 participants