Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer address in admin order details like company name in not work website wise #23254

Closed
faizanbegsm opened this issue Jun 14, 2019 · 8 comments · Fixed by #33004
Closed
Assignees
Labels
Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@faizanbegsm
Copy link

faizanbegsm commented Jun 14, 2019

Preconditions (*)

  1. Magento version 2.2.7
  2. On Multiwebsite
  3. In Admin view order details customer address information Billing and Shipping. Company name not showing website wise it only show when Show Company setting under customer configuration is set as optional in base website whose id is 1. If you go to different scope in setting and change to no for second website there is no changes occurred.

Steps to reproduce (*)

  1. In Admin view order details customer address information Billing and Shipping. Company name not showing website wise it only show when Show Company setting under customer configuration is set as optional in base website whose id is 1. If you go to different scope in setting and change to no for second website there is no changes occurred.
  2. Attributes like company name, vat show etc depends on website whose id is 1 in admin order details.
  3. Suppose you have an order of france website and its id is website id is 2. If you change the setting in website scope like Show Company to Optional and in default Show Company is No then in France order in admin section customer address details Company name not visible. but when you change the setting in first website whose id is 1 then it show the company name in address admin order details.

Expected result (*)

  1. Company name, Show Fax etc attributes must show in order details customer address information website wise setting.

Actual result (*)

  1. Company name, Show Fax etc attributes work only on website whose id is 1.
@m2-assistant
Copy link

m2-assistant bot commented Jun 14, 2019

Hi @faizanbegsm. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@faizanbegsm do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jun 14, 2019
@AlexWorking AlexWorking self-assigned this Jun 14, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 14, 2019

Hi @AlexWorking. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@m2-assistant
Copy link

m2-assistant bot commented Jun 14, 2019

Hi @engcom-qa-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 14, 2019
@ghost ghost unassigned engcom-Bravo Jun 14, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-qa-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-17497, MC-17498 were created

Issue Available: @engcom-qa-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jun 14, 2019
@krzysztofjasniok krzysztofjasniok self-assigned this Sep 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 15, 2019

Hi @krzysztofjasniok. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@krzysztofjasniok
Copy link

Issue not reproducible on 2.3-develop.

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Sep 16, 2019

Hi @krzysztofjasniok. The issue is still reproduced on the latest develop version. If You haven't manage to reproduce it that's only because You missed something in the order of reproduction. In fact the issue comes not from the website's id=1 but from the setting of Default Website. The confusion origins from after You install a fresh instance the default website is the one with id=1.
First, I think the bug here begins already in that Show Company field in Customer Configuration -> Name and Address Options should not affect Backend as those options are designated for Frontend. The second is the Default Website setting. So have two websites with ids 1 (set as default website) and 2 (Show Company = "optional" for both of them); have two customers on each of the websites with addresses containing some companies' names; and finally have two orders created by those customers. So there has to be one order per website. Now go to admin and watch each order's, lets say, Billing Address - You shall see the according company's name in there. Now change Show Company to "no" for the website with the id of 2 and go back to watch the orders - the situation remains the same: in both orders the addresses contain the company's name. Then set website with id 2 as the default one and get back to watch the orders - companies' names are missing in orders' addresses.

@engcom-Bravo engcom-Bravo reopened this Sep 16, 2019
@ghost ghost unassigned krzysztofjasniok Sep 16, 2019
@ghost ghost removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 16, 2019
@engcom-Bravo engcom-Bravo added Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 16, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-20168 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 16, 2019
@magento-engcom-team magento-engcom-team added this to Ready for Dev in Community Backlog Mar 24, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@magento-engcom-team magento-engcom-team added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Priority: P3 May be fixed according to the position in the backlog. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Oct 8, 2020
@sidolov sidolov added this to Ready for Development in High Priority Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Dev in Community Backlog Oct 20, 2020
@ghost ghost removed this from Ready for Development in Low Priority Backlog Oct 20, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Apr 15, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog May 13, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
8 participants