Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception occurs when attempting to unset persistence cookie after visiting checkout #24218

Closed
itmsenior opened this issue Aug 21, 2019 · 18 comments
Labels
Component: Customer Fixed in 2.3.x The issue has been fixed in 2.3 release line Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@itmsenior
Copy link

itmsenior commented Aug 21, 2019

Preconditions (*)

  1. Magento v2.3.2
  2. Enable Persistent Shopping Cart

Steps to reproduce (*)

  1. Enable Persistence in in Magento Admin
  2. Sign-in as a customer and check the "Remember me" persistence checkbox on login.
  3. Add product to cart
  4. Trigger persistence by deleting phpsession cookie from browser
  5. Navigate to checkout
  6. Enter address information, select shipping option and press next
  7. Don't select a payment method, instead return to the homepage by pressing logo
  8. Press the "Not you?" link to clear persistence

Expected result (*)

  1. Persistence is cleared
  2. User is redirected to sign-in page

Actual result (*)

  1. Exception occurs: "The shipping address is missing. Set the address and try again"
    image

Triggered by:

if (!$shippingAddress->getCountryId()) { // Remove empty quote address $this->quoteAddressResource->delete($shippingAddress); throw new StateException(__('The shipping address is missing. Set the address and try again.')); }
Line 206 in vendor\magento\module-quote\Model\ShippingMethodManagement.php

@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2019

Hi @itwebdev2. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@itwebdev2 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Aug 21, 2019
@itmsenior
Copy link
Author

Confirmed issue on vanilla 2.3-develop instance.

@itmsenior itmsenior changed the title Exception when attempting to unset persistence cookie Exception occurs when attempting to unset persistence cookie after visiting checkout Aug 21, 2019
@engcom-Bravo engcom-Bravo self-assigned this Aug 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 21, 2019

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added Component: Customer Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 22, 2019
@ghost ghost unassigned engcom-Bravo Aug 22, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-19560 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Aug 22, 2019
@serhiyzhovnir serhiyzhovnir self-assigned this Aug 22, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 22, 2019

Hi @serhiyzhovnir. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@itmsenior
Copy link
Author

@magento give me 2.3.1 instance

@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2. Thank you for your request. I'm working on Magento 2.3.1 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2, here is your Magento instance.
Admin access: https://i-24218-2-3-1.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@itmsenior
Copy link
Author

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2, here is your Magento instance.
Admin access: https://i-24218-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost unassigned serhiyzhovnir Sep 27, 2019
@itmsenior
Copy link
Author

@magento give me 2.3.3 instance

@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2. Thank you for your request. I'm working on Magento 2.3.3 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2, here is your Magento instance.
Admin access: https://i-24218-2-3-3.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@magento-engcom-team magento-engcom-team added this to Ready for Dev in Community Backlog Mar 24, 2020
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label May 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2.

Thank you for your report and collaboration!

The issue was fixed by Magento team. The fix was delivered into magento/magento2:2.3-develop branch(es).
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2.

Thank you for your report and collaboration!

The issue was fixed by Magento team. The fix was delivered into magento/magento2:2.3-develop branch(es).
Related commit(s):

The fix will be available with the upcoming 2.3.5 release.

@itmsenior
Copy link
Author

@magento-engcom-team Commits are 404?

@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @itwebdev2.

Thank you for your report and collaboration!

The issue was fixed by Magento team. The fix was delivered into magento/magento2:2.4-develop branch(es).
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@ghost ghost moved this from Ready for Dev to Done (last 30 days) in Community Backlog Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Fixed in 2.3.x The issue has been fixed in 2.3 release line Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

No branches or pull requests

5 participants