Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image in minicart is blurred on iPhone #24735

Closed
ihor-sviziev opened this issue Sep 26, 2019 · 16 comments
Closed

Image in minicart is blurred on iPhone #24735

ihor-sviziev opened this issue Sep 26, 2019 · 16 comments
Assignees
Labels
Area: Design/Frontend Component: Framework/Image Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 26, 2019

Preconditions (*)

  1. Magento 2.3.2 with demo data

Steps to reproduce (*)

  1. Add some product to cart
  2. Go to shopping cart
  3. Open minicart and compare images that rendered on minicart and on shopping cart pages

Expected result (*)

  1. Both images should have good quality

Actual result (*)

  1. Image on cart page looks good, while image in minicart is blurred
    image
@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2019

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ihor-sviziev do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Sep 26, 2019
@ajijshekh123 ajijshekh123 self-assigned this Sep 26, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2019

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123 ajijshekh123 added Area: Design/Frontend Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Minicart labels Sep 26, 2019
@ajijshekh123
Copy link

Give me @magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-24735-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ajijshekh123
Copy link

I have reproduced the issue in iPhoneXS Device.

See attached the screenshot:
Product Image Issue_iPhoneXS

@ajijshekh123 ajijshekh123 added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Sep 26, 2019
@ghost ghost unassigned ajijshekh123 Sep 26, 2019
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 26, 2019
@magento-engcom-team
Copy link
Contributor

@ajijshekh123 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@ajijshekh123 ajijshekh123 added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 26, 2019
@magento-engcom-team
Copy link
Contributor

@ajijshekh123 Thank you for verifying the issue.

Unfortunately, not enough information was provided to acknowledge ticket. Please consider adding the following:

  • Add "Component: " label(s) to this ticket based on verification result. If uncertain, you may follow the best guess

Once all required information is added, please add label "Issue: Confirmed" again.
Thanks!

@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 26, 2019
@ajijshekh123 ajijshekh123 added Component: Framework/Image Product Image Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 26, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-20486 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 26, 2019
@kovinka
Copy link

kovinka commented Sep 27, 2019

@magento I'm working on it

@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @kovinka! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and self-assign the issue.

@kovinka kovinka self-assigned this Sep 27, 2019
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2019

Hi @kovinka. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


@dmdanilchenko dmdanilchenko mentioned this issue Sep 27, 2019
4 tasks
@sidolov sidolov removed the Minicart label Sep 27, 2019
@ghost ghost assigned dmdanilchenko Oct 2, 2019
@ghost ghost unassigned kovinka Oct 22, 2019
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Mar 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev. Thank you for your report.
The issue has been fixed in #24743 by @dmdanilchenko in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@danieldespainTLS
Copy link

This was a terrible fix! Now, with the width/2 code, you just get a teeny tiny image in a big white space. The correct solution would be to put an image that's LARGER than the 75 pixel container into the space to accommodate the @2x resolution.

@palviggi-flagbit
Copy link

I'm too getting half sized images in the minicart on desktop now. was this tested?
i had to revert this one and app/code/Magento/Checkout/view/frontend/web/template/summary/item/details/thumbnail.html (same problem, no ticket associated)

@danieldespainTLS
Copy link

We discovered that it was partly our fault. The newer version of Magento updated the view.xml file to a value of 150 and then the .phtml file divides it (value from XML) in half. We had modified the view.xml and still had the old value that was then divided by the phtml to result in tiny images. If you haven't modified the xml or .phtml, then Magento works correctly "out of the box" but if you modified one or the other, you need to integrate the change into your code.

the XML:
app/design/frontend/{{vendor}}/{{module}}/etc/view.xml

look for

we had values of 75 (the old values). We removed this XML node to fix our problem, or you could change it to 150 which is what Magento uses by default now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Component: Framework/Image Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: done Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

No branches or pull requests

9 participants