Marketing Email preview doesn't work with enabled js minification #25068

ihor-sviziev · 2019-10-15T11:00:11Z

Preconditions (*)

Magento 2.3.2-p2, Magento 2.3.3, Magento 2.3-devlop
Enable JS minification in Admin >> Stores >> Configuration >> JavaScript Settings >> "Minify JavaScript Files" set to "Yes"
Switch magento to production mode

Steps to reproduce (*)

Go to Admin >> Marketing >> Communications >> Email Templates
Click "Add New Template"
Select "New Order" template
Click "load template" button
Fill up "Template Name" with "New Order"
Click "Save Template" button
In the email templates grid click on "Preview" link in "Actions" column

Expected result (*)

You should see email template preview in opened popup
There should not be any JS errors

Actual result (*)

Email Preview popup is empty
We have JS error

Failed to load resource: the server responded with a status of 404 ()
Uncaught Error: Script error for: jquery

m2-assistant · 2019-10-15T11:00:13Z

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

Summary of the issue
Information on your environment
Steps to reproduce
Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ihor-sviziev do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

yes
no

Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-assistant · 2019-10-15T11:02:50Z

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
Details
If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
4. Verify that the issue is reproducible on 2.3-develop branch
Details
- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
5. Add label Issue: Confirmed once verification is complete.
6. Make sure that automatic system confirms that report has been added to the backlog.

shikhamis11 · 2019-10-15T11:03:46Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-10-15T11:03:48Z

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-10-15T11:04:28Z

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-25068-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

shikhamis11 · 2019-10-15T11:33:31Z

Hello @ihor-sviziev
thank you for reporting this issue , I checked it on 2.3-develop instance email template preview works fine , there are some errors on console but those are related to CORS .
Can you Please take a look ?

ihor-sviziev · 2019-10-15T11:38:34Z

@shikhamis11,
I see that changed from 2.3.3 and 2.3.2-p2 wasn't merged to 2.3-develop branch, so it will appear once it will be merged. As for now - you could try to reproduce it in 2.3.3.

Just check files contents:

ihor-sviziev · 2019-10-23T06:00:46Z

Hi @shikhamis11,
Now 2.3.3 release was merged, could you double check it again?

ihor-sviziev · 2019-10-25T14:11:45Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-10-25T14:11:47Z

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.3-develop instance for you

ihor-sviziev · 2019-10-28T11:38:21Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-10-28T11:38:23Z

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-10-28T11:39:04Z

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-25068-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ihor-sviziev · 2019-10-28T11:52:11Z

@shikhamis11 just updated steps to reproduce, we have to have production mode, while on test instance we don't have production mode :(

shikhamis11 · 2019-10-28T12:12:40Z

Hello @ihor-sviziev you can have production mode in test instance
Just add pub/testing in instance url

ihor-sviziev · 2019-10-28T12:16:30Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-10-28T12:16:35Z

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.3-develop instance for you

ihor-sviziev · 2019-10-28T12:20:26Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-10-28T12:20:27Z

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-10-28T12:21:16Z

Hi @ihor-sviziev, here is your Magento instance.
Admin access: https://i-25068-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

ihor-sviziev · 2019-10-28T13:24:59Z

I was able to reproduce this issue on test instance.

Just updated issue description with exact steps to reproduce and screenshots of actual result.

magento-engcom-team · 2019-10-28T13:29:10Z

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MC-22163 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

LucasCalazans · 2019-11-04T13:30:29Z

@magento give me 2.3-develop instance

magento-engcom-team · 2019-11-04T13:30:34Z

Hi @LucasCalazans. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2019-11-04T13:31:10Z

Hi @LucasCalazans, here is your Magento instance.
Admin access: https://i-25068-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

m2-assistant · 2019-12-05T23:24:23Z

Hi @arnobsh. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
2. Verify that the issue is reproducible on 2.4-develop branch
Details
- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
- If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
3. If the issue is not relevant or is not reproducible any more, feel free to close it.

Join Magento Community Engineering Slack and ask your questions in #github channel.

arnobsh · 2019-12-05T23:24:36Z

Internal Magento team is working on this issue right now

arnoudhgz · 2019-12-09T22:23:49Z

The issue is, that somehow jquery.js is requested while jquery.min.js should be loaded. A workaround until the actual solution is found is to create a symlink named jquery.js that points to jquery.min.js in pub/static/versionxxx/adminhtml/Magento/backend/en_US.

Of course replace versionxxx and en_US to your appropriate paths, versionxxx is only needed when static signing enabled.

magento-engcom-team · 2019-12-10T21:38:04Z

Hi @ihor-sviziev, @arnobsh.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

arnoudhgz · 2019-12-11T00:19:37Z

@magento-engcom-team where is the fix?

magento-engcom-team · 2019-12-12T20:06:04Z

Hi @ihor-sviziev, @arnobsh.

Thank you for your report and collaboration!

The issue was fixed by Magento team. The fix was delivered into magento/magento2:2.3-develop branch(es).
Related commit(s):

30cdbd21cc368263de5cb6259c158c6a60bc63a6

The fix will be available with the upcoming 2.3.5 release.

AlexanderSk · 2019-12-13T21:38:10Z

hello guys, i just faced this issue one 2.3.3 and searched for this ticket and that it hopefully will be fine on 2.3.5.

i would only like to note that i did try to copy paste the jsuery.min.js to jquery.js and i get an error: Uncaught SyntaxError: Unexpected end of input for jquery.js

the actual file is this one if you would like to have a look.
https://tyanabelle.com/pub/static/version1576220203/adminhtml/Magento/backend/en_US/jquery.js

Thank you for your time and effort.

magento-engcom-team · 2019-12-16T07:28:03Z

Hi @ihor-sviziev, @arnobsh.

Thank you for your report and collaboration!

The issue was fixed by Magento team. The fix was delivered into magento/magento2:2.4-develop branch(es).
Related commit(s):

e8eb43a84cb861cedda424aaf8be83aa1c6c1c29

The fix will be available with the upcoming 2.4.0 release.

linardskrumins · 2019-12-16T13:47:45Z

Hey @magento-engcom-team

Were these commits deleted? The commit page for both commits is not found

ihor-sviziev · 2019-12-17T14:59:37Z

@linardskrumins now this link available e8eb43a

adarshkhatri · 2020-05-19T00:05:46Z

Still happening in 2.3.3-p1. The system is looking for jquery.js instead of jquery.min.js.

A quick (temporary) solution would be to duplicate jquery.min.js and rename it to jquery.js in pub/static/adminhtml/Magento/backend/en_US

Eddcapone · 2021-03-29T09:35:56Z

Does not work in 2.4.2 Enterprise in production mode. I get "Blocked script execution in '' because the document's frame is sandboxed and the 'allow-scripts' permission is not set."

Is it because I have disabled the module Magento_Csp?

EDIT: Solved. It was not because of the javascript. It was caused because the included header could not get loaded, because it was set to a non existing template in "Content -> Design: Configuration -> Theme -> Transaction E-Mails". The problem was caused after copying a database to another project. The error was present in that other project only.

ihor-sviziev · 2021-03-29T10:49:15Z

@Eddcapone, it looks like a bit different issue. Could you report it separately?
Thank you!

magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 15, 2019

shikhamis11 self-assigned this Oct 15, 2019

shikhamis11 added Component: Backend Component: Email Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 28, 2019

ghost unassigned shikhamis11 Oct 28, 2019

magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 28, 2019

arnobsh self-assigned this Dec 5, 2019

magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Dec 10, 2019

magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Dec 16, 2019

magento-engcom-team closed this as completed Dec 16, 2019

Marketing Email preview doesn't work with enabled js minification #25068

Marketing Email preview doesn't work with enabled js minification #25068

Comments

ihor-sviziev commented Oct 15, 2019 • edited Loading

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

Actual result (*)

m2-assistant bot commented Oct 15, 2019 • edited by ihor-sviziev Loading

m2-assistant bot commented Oct 15, 2019 • edited by bassplayer7 Loading

shikhamis11 commented Oct 15, 2019

magento-engcom-team commented Oct 15, 2019

magento-engcom-team commented Oct 15, 2019

shikhamis11 commented Oct 15, 2019

ihor-sviziev commented Oct 15, 2019 • edited Loading

ihor-sviziev commented Oct 23, 2019

ihor-sviziev commented Oct 25, 2019

magento-engcom-team commented Oct 25, 2019

ihor-sviziev commented Oct 28, 2019

magento-engcom-team commented Oct 28, 2019

magento-engcom-team commented Oct 28, 2019

ihor-sviziev commented Oct 28, 2019

shikhamis11 commented Oct 28, 2019

ihor-sviziev commented Oct 28, 2019

magento-engcom-team commented Oct 28, 2019

ihor-sviziev commented Oct 28, 2019

magento-engcom-team commented Oct 28, 2019

magento-engcom-team commented Oct 28, 2019

ihor-sviziev commented Oct 28, 2019

magento-engcom-team commented Oct 28, 2019

LucasCalazans commented Nov 4, 2019

magento-engcom-team commented Nov 4, 2019

magento-engcom-team commented Nov 4, 2019

m2-assistant bot commented Dec 5, 2019

arnobsh commented Dec 5, 2019

arnoudhgz commented Dec 9, 2019 • edited Loading

magento-engcom-team commented Dec 10, 2019

arnoudhgz commented Dec 11, 2019

magento-engcom-team commented Dec 12, 2019

AlexanderSk commented Dec 13, 2019

magento-engcom-team commented Dec 16, 2019

linardskrumins commented Dec 16, 2019

ihor-sviziev commented Dec 17, 2019

adarshkhatri commented May 19, 2020 • edited Loading

Eddcapone commented Mar 29, 2021 • edited Loading

ihor-sviziev commented Mar 29, 2021

ihor-sviziev commented Oct 15, 2019 •

edited

Loading

m2-assistant bot commented Oct 15, 2019 •

edited by ihor-sviziev

Loading

m2-assistant bot commented Oct 15, 2019 •

edited by bassplayer7

Loading

ihor-sviziev commented Oct 15, 2019 •

edited

Loading

arnoudhgz commented Dec 9, 2019 •

edited

Loading

adarshkhatri commented May 19, 2020 •

edited

Loading

Eddcapone commented Mar 29, 2021 •

edited

Loading