New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to save page and block changes using Page Builder with enabled js minification. #25620
Comments
Hi @LordHansolo. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @LordHansolo do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-Echo. Thank you for working on this issue.
|
Hello @LordHansolo Thank you for contribution and collaboration! This issue related to Page Builder functionality which is not part of Magento Open Source. Current repository and issue tracker aimed at Magento Open Source version only and the main focus is community contribution/collaboration. It described in Issue reporting guidelines and it is a part of the issue report template:
But I have asked internal Magento team(who is working on Page Builder) about this issue and
|
Hi Lordhansolo |
Thank You @sdzhepa. In my module I created block that extends Magento\PageBuilder\Block\Adminhtml\Stage\Render and adds two additional methods
Next I created template in My module scope
Next I created Controller that extends
Next I created adminhtml/di.xml to set preference for Magento\PageBuilder\Controller\Adminhtml\Stage\Render.
Next in module.xml I add Magento_PageBuilder to sequence.
Thats all. Now Page Builder should work fine with enabled js minification. |
@LordHansolo, Could you add my Skype: john.lou@msn.com or offer yours, Thanks. |
@mugua @LordHansolo If you have an active Magento Commerce subscription you can just ask the Commerce support and they'll send you a patch. |
I have made module based on @LordHansolo reply,, it is working perfectly. |
@Parakoopa Is this patch not listed in the Downloads section our accounts on Magento.com? |
@dfelton As far as I know you have to open a support ticket and reference this GitHub issue. That's what we did and they sent us a patch. |
@sdzhepa I just want to thank you for carefully responding to the OP about this issue. There has been a habit of closing issues raised that mention Commerce Edition. Instead you chose to provide guidance anyway, and I think that's an example for Adobe to follow when dealing with the community, since Open-Source and Commerce are (for the time being) very closely related. |
Does anyone have a patch to fix this, I have try to fix it but it still doesn't work? I have used @kushaljindal92's module but it only fix js errors, it still can't save |
Does Magento just not test? It seems pretty common for production instances to minify js files. |
@minhducnho any solution |
It's happening to me in Magento 2.4.6 |
Issue reported in 2.4.5 EE, especially while using google chrome with magento running on production mode and minified js enabled. |
@anton-vidext did you use google chrome ? can you try using firefox? I'm beginning to think it's browser related issue |
I used google chrome, firefox and edge. It was happening in every browser. Disabled minified JS and CSS and I can now save page builder content. |
This is excatly what happens for me. Disabling minified doesn't help for me, but it only happens on Chrome. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-8773 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
Hi @LordHansolo Could you please explain about the isJsMinificationEnabled()) : ?>
Why did you add this in render.phtml because I have seen this template but I have not seen the script "<script src="escapeUrl($block->getRequireJsUrl()); ?>"></script>" in this template maybe Magento remove this script from the latest version. if you can let me know the reason why you add this code then may I fix it in latest version thanks in advance |
Hi @LordHansolo, Tested on the latest 2.4-develop version. Enabled “Minify JavaScript Files” in the JavaScript Settings of Store Configuration. In production mode, attempted to edit a Block/Page and save it. Despite multiple edits, changes were successfully saved. After exhaustive attempts to reproduce this issue, it has been determined that the problem is no longer reproducible. Hence we are closing this issue. Screen.Recording.2023-12-11.at.1.21.52.PM.movThanks. |
Preconditions (*)
Steps to reproduce (*)
bin/magento deploy:mode:set production
Expected result (*)
Actual result (*)
Additional Information
The text was updated successfully, but these errors were encountered: