Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to remove default text swatch value and value automatically assigning #26481

Closed
Zyles opened this issue Jan 21, 2020 · 7 comments
Closed
Labels
Component: Eav Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. stale issue Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@Zyles
Copy link

Zyles commented Jan 21, 2020

When creating a new text swatch, if you click "Is default" you can not undo it and having a blank value is no longer possible. That causes a problem for products where the swatch is optional.

That value will then automatically assign itself to any old products if they are saved, even if you did not select any text swatch value.

Preconditions (*)

  1. Magento 2.4-develop

Steps to reproduce (*)

  1. Add new text swatch attribute with 3 options
  2. Values Required = No
  3. Do NOT click any "Is Default"
  4. Save attribute
  5. Assign attribute to attribute set Default
  6. Create new product. You can see that the swatch selection is BLANK = CORRECT
  7. Edit the attribute again and select "Is Default" on any selection
  8. Save attribute
  9. Try to edit attribute again, now it is impossible to remove the default option
  10. Create a new product again, the default selection is prefilled and you have to manually select "blank" even if the value is supposed to be OPTIONAL with "Values Required"

This also causes a VERY annoying side-bug:

  1. Create ANOTHER text swatch attribute
  2. Values Required = No
  3. Add 3 options and click "Is Default" on any
  4. Save attribute and add to attribute set
  5. Clear Cache etc.
  6. Go into an old product added in previous steps and look at the new swatch value, it should still be blank = correct
  7. Save product without doing any changes.
  8. Look at the new swatch value. Suddenly it has a value assigned! BY ITSELF!

This causes MAJOR problems.

If you edit an attribute set with a new text swatch. The "default value" will be assigned on ALL products automatically when that product is edited without the intent of the catalog manager.

In fact ANY edit to the product will make it change to the default text swatch value even if you want it to be blank.

Expected result (*)

A text swatch value should not assign its default value by itself without the catalog managers input.

Actual result (*)

Text swatch value is assigned by itself, even if left blank upon product save when new attributes are added to the attribute group.

issue_26481_1

@m2-assistant
Copy link

m2-assistant bot commented Jan 21, 2020

Hi @Zyles. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Zyles do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Jan 21, 2020
@engcom-Hotel engcom-Hotel self-assigned this Jan 22, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 22, 2020

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added Component: Eav Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jan 22, 2020
@ghost ghost unassigned engcom-Hotel Jan 22, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Jan 22, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Hotel
Thank you for verifying the issue. Based on the provided information internal tickets MC-30656 were created

Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added this to Ready for Dev in Community Backlog Mar 24, 2020
@ghost ghost assigned zaximus84 Apr 7, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Apr 7, 2020
@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 17, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Jun 17, 2020
@sdzhepa sdzhepa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels Jun 17, 2020
@ghost ghost unassigned zaximus84 Sep 21, 2020
@ghost ghost moved this from Ready for Dev to PR In Progress in Community Backlog Sep 21, 2020
@ghost ghost removed the Progress: ready for dev label Sep 21, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@Alex7Lem
Copy link

Alex7Lem commented Oct 7, 2020

Solution of the problem:
Create a new value for the attribute.
Set the new attribute value to the default.
Remove new attribute value.

@ghost ghost unassigned zaximus84 Oct 19, 2020
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in Low Priority Backlog Oct 19, 2020
@m2-community-project m2-community-project bot added Progress: ready for dev and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 19, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from PR In Progress in Community Backlog Nov 13, 2020
@stale
Copy link

stale bot commented Jan 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Jan 28, 2021
@stale stale bot closed this as completed Feb 11, 2021
@m2-community-project m2-community-project bot moved this from Ready for Development to Done in Low Priority Backlog Feb 11, 2021
@magento-engcom-team magento-engcom-team removed the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Feb 11, 2021
@magento-engcom-team
Copy link
Contributor

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

Please feel free to comment or reopen according to the Issue reporting guidelines
the ticket if you are still facing this issue on the latest 2.x-develop branch. Thank you for collaboration.

@Zyles
Copy link
Author

Zyles commented Feb 12, 2021

Closing a bunch of tickets does not solve them and does not make Magento 2 a better product just FYI. The problems are still there and the platform is in a very buggy sad state.

But we don't care anymore, we are dropping Magento 2 in a month for a better platform and getting off this trainwreck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Eav Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. stale issue Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
6 participants