Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Billing_region field name on customer grid #26679

Open
ageffray opened this issue Feb 3, 2020 · 13 comments · May be fixed by #26681
Open

Billing_region field name on customer grid #26679

ageffray opened this issue Feb 3, 2020 · 13 comments · May be fixed by #26681
Assignees
Labels
Area: UI Framework Component: Sales Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@ageffray
Copy link

ageffray commented Feb 3, 2020

Summary (*)

On sales_order_create_customer_block.xml column for billing region is missnamed "billing_regione" instead of "billing_region"

Examples (*)

in sales_order_create_customer_block.xml:73 and on sales/Model/ResourceModel/Order/Customer/Collection.php:41

Proposed solution

Rename "billing_regione" to "billing_region"

@ageffray ageffray added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 3, 2020
@magento-deployment-service
Copy link

Thanks for opening this issue!

@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2020

Hi @ageffray. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@ageffray do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 3, 2020
@engcom-Bravo engcom-Bravo self-assigned this Feb 3, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 3, 2020

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added Component: Sales Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 3, 2020
@ghost ghost removed the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Feb 3, 2020
@ghost ghost unassigned engcom-Bravo Feb 3, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Feb 3, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-31038 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ageffray ageffray linked a pull request Feb 3, 2020 that will close this issue
4 tasks
@ghost ghost assigned ageffray Feb 3, 2020
@magento-engcom-team magento-engcom-team added this to PR In Progress in Community Backlog Mar 24, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Jun 17, 2020

Hello @ageffray
fyi: @engcom-Bravo

Could you please provide more details about the issue?

  • How it impacts product or functionality?
  • What functional flows are broken due to this issue?
  • what is the business value?

Or its just typo that does not affect any functionality?

@ageffray
Copy link
Author

hello @sdzhepa

There is no impact on features or any kind of bug it's only typo

@sdzhepa sdzhepa added Triage: Ready for Triage Issue is ready to me triaged with Product Manager Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels Jun 17, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Jun 17, 2020
@sidolov sidolov added this to Ready for Development in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: ready for dev labels Sep 24, 2020
@mattgrul
Copy link

@magento I am working on it

@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2021

Hi @mattgrul! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@mattgrul
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2021

Hi @mattgrul! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@mattgrul
Copy link

@magento I am working on it

@m2-community-project m2-community-project bot removed this from Ready for Dev in Community Backlog Jan 17, 2021
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Jan 17, 2021
@mattgrul mattgrul removed their assignment Jan 18, 2021
@engcom-Lima engcom-Lima added Reported on 2.4.x Indicates original Magento version for the Issue report. Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 22, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9048 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: Sales Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

7 participants