-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cart unit item price is shown in wrong currency if custom_price is used #27161
Comments
Hi @borriglione. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. @borriglione do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?
|
Hi @engcom-Bravo. Thank you for working on this issue.
|
Hello @borriglione Thank you for your report. We are able to reproduce this behavior on Magento 2.4-develop, and we have added additional info to the description |
Hi @borriglione |
Took me a while to figure out but vendor/magento/module-tax/Model/Sales/Total/Quote/CommonTaxCollector.php:692
should be:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions! |
@magento give me 2.4-develop instance |
Hi @koushikch7. Thank you for your request. I'm working on Magento instance for you. |
Hi @koushikch7, here is your Magento Instance: https://257cc8da383afae792dbcc1ffbd8bfc4-2-4-develop.instances.magento-community.engineering |
I'm facing exactly the same issue even with version 2.4.2. The changing currency via default switcher prices remain the same on shopping cart. |
I could find a solution for this using currency convert function in this class [ \Magento\Directory\Model\Currency ] $currency is instance of \Magento\Directory\Model\Currency then $quoteItem->setCustomPrice($correct_price); this was not working on 2.3.x but now it looks working on 2.4.3 |
I fixed the issue. Please check this : #33134 (comment) |
The core bug it's not solved with this. It's more a workaround. Please check out my comments here @maheshmakwana-code : #33134 (comment) |
Preconditions
Steps to reproduce (*)
Sample:
Expected result (*)
I would expect to see:
Actual result (*)
It seems that
quote_item.custom_price
is currently always stored in base currency which is then not converted during cart item output.Suggestion
Best practice would be to have 4 columns for quote_item
Additional info from engcom
Stores - Currency - Currency Rates
Magento 2 Database, quote_item table
custom_price
set to 10Storefront, 2 itmes added to Cart
The text was updated successfully, but these errors were encountered: