Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom category layout update not affecting products #27285

Closed
codedge opened this issue Mar 13, 2020 · 9 comments · Fixed by #32217
Closed

Custom category layout update not affecting products #27285

codedge opened this issue Mar 13, 2020 · 9 comments · Fixed by #32217
Assignees
@engcom-Kilo
Labels
Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog

Comments

@codedge
Copy link

codedge commented Mar 13, 2020 •
edited
Loading

Preconditions (*)

  1. Magento 2.3.4

Steps to reproduce (*)

  1. Create a custom layout update

I created a file catalog_category_view_selectable_276_noindexnofollow.xml in app/design/frontend/<VENDOR>/<THEME>/Magento_Catalog/layout. That file should set noindex, nofollow for a certain category.

<?xml version="1.0"?>
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
    <head>
        <meta name="robots" content="NOINDEX,NOFOLLOW"/>
    </head>
</page>

So we imagine we have a category with ID 276, named Shirts.

  1. In Admin got to the category with ID 276 and select this update via the Custom Layout update dropdown. Please see that I also set Apply Design to Products.

layout_update

  1. Go to a sub category of this former category and enable Use parent category settings. Additionally I enabled Apply Design to Products for this category as well.

This is a subcategory of Shirts, named Soccer Shirts.

layout_update_sub

  1. In the frontend check the head section of this three pages:
  • Category page Shirts
  • Category page Soccer shirts
  • Product page of category Soccer shirts

Expected result (*)

  1. ✔️ The category page Shirts should have <meta name="robots" content="NOINDEX,NOFOLLOW">:
  2. ✔️ The category page Soccer shirts should have <meta name="robots" content="NOINDEX,NOFOLLOW">
  3. ✔️ The product page of a product of Soccer shirts should have <meta name="robots" content="NOINDEX,NOFOLLOW">:

Actual result (*)

  1. ✔️ The two category pages do have the entry <meta name="robots" content="NOINDEX,NOFOLLOW">
  2. ❌ The product page of the sub category Soccer shirts does not have this entry
@m2-assistant
Copy link

m2-assistant bot commented Mar 13, 2020

Hi @codedge. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@codedge do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@codedge
Copy link
Author

codedge commented Mar 13, 2020

I don't know how I should reproduce this in a demo instance as I cannot create a custom XML layout file there.

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Mar 19, 2020
@magento-engcom-team magento-engcom-team added this to Ready for QA in Community Backlog Mar 24, 2020
@mrtuvn
Copy link
Contributor

mrtuvn commented Apr 26, 2020

#26901

@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@sidolov sidolov added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 21, 2020
@ghost ghost removed this from Ready for QA in Community Backlog Oct 21, 2020
@ghost ghost removed this from Ready for Grooming in Low Priority Backlog Oct 21, 2020
@ghost ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 21, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.4 Indicates original Magento version for the Issue report. label Nov 13, 2020
@stale
Copy link

stale bot commented Jan 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label Jan 29, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Feb 2, 2021

Not stale
I also can reproduced issue like description

@stale stale bot removed the stale issue label Feb 2, 2021
@engcom-Alfa engcom-Alfa self-assigned this Feb 2, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 2, 2021

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Component: Catalog Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Feb 2, 2021
@m2-community-project m2-community-project bot added this to Dev In Progress in Low Priority Backlog Feb 2, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Feb 2, 2021
@engcom-Alfa engcom-Alfa removed the Priority: P3 May be fixed according to the position in the backlog. label Feb 2, 2021
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Feb 2, 2021
@engcom-Alfa engcom-Alfa added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Feb 2, 2021
@m2-community-project m2-community-project bot added this to Dev In Progress in High Priority Backlog Feb 2, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Feb 2, 2021
@engcom-Alfa engcom-Alfa removed the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Feb 2, 2021
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 2, 2021
@engcom-Alfa engcom-Alfa moved this from Dev In Progress to Ready for Development in High Priority Backlog Feb 2, 2021
@engcom-Alfa engcom-Alfa removed their assignment Feb 2, 2021
@engcom-Alfa engcom-Alfa added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 2, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-40736 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Feb 15, 2021
@engcom-Kilo engcom-Kilo self-assigned this Feb 15, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 15, 2021

Hi @engcom-Kilo. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Kilo engcom-Kilo mentioned this issue Feb 18, 2021
Merged
4 tasks
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Feb 18, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Mar 3, 2021
@yangshuqiugithub
Copy link

Is this method used for custom CMS pages? What if you want to create multiple CMS pages with the same layout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Kilo engcom-Kilo

Labels
Component: Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom category layout update not affecting products. magento-tsg/magento2
8 participants
@mrtuvn @sdzhepa @codedge @yangshuqiugithub @magento-engcom-team @engcom-Alfa @engcom-Kilo @github-jira-sync-bot