2 error messages in Cart when product is out of stock

[stkrelax]

Preconditions (*)

Magento 2.3.3, CatalogInventory Modules and MSI Modules enabled

1. You need a product
2. you must be able to change qty of that product

Steps to reproduce (*)

1. put product in Cart
2. change qty to 0 and outofstock
3. press f5 in cart

Expected result (*)

1. one message stating that the product is out of stock appears in the list of the cartitems

Actual result (*)

1. two message stating that the product is out of stock appear
   This product is out of stock. --> from CatalogInventory
   There are no source items with the in stock status --> from Magento_InventorySales

[m2-assistant]

Hi @stkrelax. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@stkrelax do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @sudheers-kensium. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[sudheers-kensium]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @sudheers-kensium. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @sudheers-kensium, here is your Magento instance.
Admin access: https://i-27469-2-4-develop.instances.magento-community.engineering/admin_9211
Login: 86df0572 Password: 502a99e4d5a9
Instance will be terminated in up to 3 hours.

[stkrelax]

@sudheers-kensium thank for having a look. Any questions than just ask i will try to answer immediatly

[magento-engcom-team]

✅ Confirmed by @sudheers-kensium
Thank you for verifying the issue. Based on the provided information internal tickets MC-32861 were created

Issue Available: @sudheers-kensium, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[stkrelax]

Adittional notice :
there is also a case where this happens when you have a product instock and qty 1
and inventory reservation totals -2 when cart qty is 1
Same case but other Messages.

[gwharton]

#24191

[neerajchand]

@magento I am working on it

[m2-assistant]

Hi @neerajchand! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and self-assign the issue.

[m2-assistant]

Hi @madhurajawat. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[madhurajawat]

@magento I need to fork MSI directory. Can you please provide the permission
Thanks.

[madhurajawat]

@stkrelax There is code added in InventorySales module di.xml. with this code getting 2 errors.
VirtualType " IsProductSalableForRequestedQtyConditionOnAddToCart "

<item name="is_any_source_item_in_stock" xsi:type="array">
	<item name="required" xsi:type="boolean">true</item>
	<item name="object" xsi:type="object">Magento\InventorySales\Model\IsProductSalableForRequestedQtyCondition\IsAnySourceItemInStockCondition</item>
</item>

We can remove this code.

[stkrelax]

@madhurajawat will have a look at it

[stkrelax]

sry we decided to disable msi. Other oversale reasons are the cause.

[jtomaszewski]

Uhm, what exactly happened here? Has it been fixed? If not, why did this issue has been closed?

It stills occurs at our Magento, 2.4.1 version.

[jtomaszewski]

One of the errors is produced by this:

And the other by this:

The fix should probably be:

• consolidate those validators into one, so that only one of them is fired, (or make one do the job of two), or
• when adding "this product is out of stock" error message, do not add it, if one is already existant on it.

[NachoVidalGolosinas]

Anyone know any way to fix this?

[sprajapat770]

@NachoVidalGolosinas run this command in your database terminal.

INSERT IGNORE INTO inventory_source_item (source_code, sku, quantity, status)
select 'default', sku, qty, stock_status from (cataloginventory_stock_status as lg join catalog_product_entity as prd on((lg.product_id = prd.entity_id)))