Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missaligned fields on the Customer Login form #28059

Closed
gjportegies opened this issue Apr 30, 2020 · 12 comments · Fixed by #28084
Closed

Missaligned fields on the Customer Login form #28059

gjportegies opened this issue Apr 30, 2020 · 12 comments · Fixed by #28084
Assignees
Labels
Component: Customer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@gjportegies
Copy link

gjportegies commented Apr 30, 2020

Preconditions (*)

  1. Magento CE 2.3.5-p1 vanilla without sample data is installed.
  2. Magento Blank Theme is used.
  3. Screen/Browser width >= 768px.

Steps to reproduce (*)

  1. Login to the admin panel.
  2. Navigate to the Content -> Design -> Configuration.
  3. Open the Global Store and set the applied theme to 'Magento Blank'.
  4. Clean the cache(s).
  5. Open the storefront and navigate to the 'Sign In' page (/customer/account/login/)
  6. See the input fields on the Customer Login form are not stroking with the design of all other forms on the default Blank Theme.

Expected result (*)

The input fields on the form should be inline with the labels (Like all other forms in the Blank Theme).

Expected Result
Schermafbeelding 2020-04-30 om 11 41 36

Actual result (*)

The input fields are shown below the labels and not aligned.

Actual Result
Schermafbeelding 2020-04-30 om 11 48 50

Additional information

On the Magento 2.4-develop instance the issue looks fixed. But this is not stroking with the styling of all the other form fields design of the Magento Blank theme.

Result on 2.4-develop
Schermafbeelding 2020-04-30 om 12 00 23

On the Magento 2.3.5-p1 the issue is probably caused by the following css line:

Schermafbeelding 2020-04-30 om 12 02 45

@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2020

Hi @gjportegies. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@gjportegies do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog Apr 30, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 30, 2020
@krishprakash krishprakash self-assigned this Apr 30, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 30, 2020

Hi @krishprakash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@krishprakash
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your Magento instance.
Admin access: https://i-28059-2-4-develop.instances.magento-community.engineering/admin_dbce
Login: 053601f6 Password: 5c9703584465
Instance will be terminated in up to 3 hours.

@ghost ghost assigned mrtuvn May 2, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog May 2, 2020
@krishprakash krishprakash added Component: Customer Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 4, 2020
@ghost ghost unassigned krishprakash May 4, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @krishprakash
Thank you for verifying the issue. Based on the provided information internal tickets MC-33937 were created

Issue Available: @krishprakash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 4, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented May 6, 2020

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, here is your Magento instance.
Admin access: https://i-28059-2-4-develop.instances.magento-community.engineering/admin_b143
Login: b508383e Password: 0338fa230159
Instance will be terminated in up to 3 hours.

@sdzhepa
Copy link
Contributor

sdzhepa commented May 6, 2020

Hello @mrtuvn
fyi: @krishprakash

I cannot reproduce this issue using steps from precondition on the latest 2.4-develop branch
Probably it was already fixed and we can close this issue
or some steps/preconditions are missed

Luma: 768x1024 and 1024x768
LUMA_28059

Blank: 768x1024 and 1024x768
Blank_28059

UPDATE:
It seems I missed part expected results and additional information.
Lets summarise:

  1. On the latest code of 2.4-develop we do not have like "shifted" titles. Titles are under input.
  2. But the only issue is general styling for the Blank Theme.
  • in the Luma theme, all titles are placed UNDER the input fields
  • in the Blank theme, all titles are placed on the LEFT side of input fields
    2020-05-06_15-26-36

@sdzhepa sdzhepa added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels May 6, 2020
@ghost ghost removed the Progress: needs update label May 6, 2020
@sdzhepa sdzhepa removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label May 6, 2020
@sdzhepa sdzhepa added the Triage: Ready for Triage Issue is ready to me triaged with Product Manager label May 6, 2020
@gjportegies
Copy link
Author

@sdzhepa did you read my comment on the additional information?

On the Magento 2.4-develop instance the issue looks fixed. But this is not stroking with the styling of all the other form fields design of the Magento Blank theme.

@ghost ghost added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label May 7, 2020
@sdzhepa sdzhepa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels May 8, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 21, 2020
@slavvka slavvka closed this as completed May 21, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog May 21, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot removed this from Done (last 30 days) in Community Backlog Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Customer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: done Reported on 2.3.5-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Development

Successfully merging a pull request may close this issue.

6 participants