Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] magento/magento2#: GraphQL. Mutation: sendEmailToFriend. Test coverage for “Please provide Email of sender.” #28138

Closed
4 tasks
ghost opened this issue May 7, 2020 · 1 comment · Fixed by #28034
Assignees
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.

Comments

@ghost
Copy link

ghost commented May 7, 2020

This issue is automatically created based on existing pull request: #28034: magento/magento2#: GraphQL. Mutation: sendEmailToFriend. Test coverage for “Please provide Email of sender.”


Description (*)

PR provides a test coverage for Please provide Email of sender. error of sendEmailToFriend miutation.

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. GraphQl query
mutation {
    sendEmailToFriend(
        input: {
                product_id: 1
                sender: {
                    name: "Name"
                    email: ""
                    message: "Lorem Ipsum"
                }
                recipients: [
                    {
                        name: "Recipient Name 1"
                        email:"recipient1@mail.com"
                    },
                    {
                        name: "Recipient Name 2"
                        email:"recipient2@mail.com"
                    }
                ]
        }
    ) {
        sender {
            name
            email
            message
        }
        recipients {
            name
            email
        }
    }
}

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@ghost ghost assigned atwixfirster May 7, 2020
@ghost ghost added this to PR In Progress in Community Backlog May 7, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 7, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 7, 2020
@slavvka
Copy link
Member

slavvka commented Jun 5, 2020

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #28034 by @atwixfirster in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 5, 2020
@slavvka slavvka closed this as completed Jun 5, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 5, 2020
@ghost ghost added the Progress: done label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
3 participants