Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to change sort order of custom option values over several pages in product edit view #28153

Open
norgeindian opened this issue May 8, 2020 · 37 comments
Labels
Area: UI Framework Component: Admin Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@norgeindian
Copy link

Preconditions (*)

  1. Magento 2.3.4

Steps to reproduce (*)

  1. Create a new simple product in the backend
  2. Add a custom option of type drop-down
  3. Add 21 values, the last value appears on a new page.
  4. Try to move the last value to another position on the first page.

Expected result (*)

  1. I would assume that it is possible to sort the values using the drag and drop functionality, even over several pages.

Actual result (*)

  1. It is not possible to move any value to another page using the drag and drop functionality.
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2020

Hi @norgeindian. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@norgeindian do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@ghost ghost added this to Ready for QA in Community Backlog May 8, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 8, 2020
@ajijshekh123 ajijshekh123 self-assigned this May 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 8, 2020

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@mahesh-rajawat
Copy link
Member

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Magento instance deployment temporary unavailable due to service maintenance.

@mahesh-rajawat
Copy link
Member

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Magento instance deployment temporary unavailable due to service maintenance.

@ajijshekh123
Copy link

Hello @norgeindian,
I have reviewed the custom values in the Simple product.
Now, 20 Fixed values are displaying in the first page and then after other values are showing.
See attached the screenshot:

New1

New2

@norgeindian - This is not an issue. This is a feature of the Magento Framework.

Let me know if anything missing from my side.

Thanks.

@ajijshekh123 ajijshekh123 added Component: Admin Component: Catalog feature request Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 15, 2020
@ghost ghost unassigned ajijshekh123 May 15, 2020
@ghost ghost moved this from Ready for QA to Ready for Dev in Community Backlog May 15, 2020
@ghost ghost removed the Progress: ready for QA label May 15, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 15, 2020
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented May 15, 2020

✅ Confirmed by @ajijshekh123
Thank you for verifying the issue. Based on the provided information internal tickets MC-34356 were created

Issue Available: @ajijshekh123, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

https://jira.corp.adobe.com/browse/AC-770

@norgeindian
Copy link
Author

@ajijshekh123 , thanks for checking, but I assume, that we speak of different things here.
As far as I can see, you checked, that the first 20 entries are on one page and all additional values are added to another page.
That's alright, I have no issue with that.

Put please try now, like I wrote in step 4 of my issue description, to move for example value 22 of your list between values 10 and 11 on the first page, to change the order the values appear in the frontend.
To change the order I only see the Drag & Drop functionality and this does not work over several pages.
Please be so kind and check again, that is actually an issue.

@ajijshekh123
Copy link

@norgeindian - Is it feasible to send a video?

@norgeindian
Copy link
Author

@ajijshekh123 sorry, in my eyes it's kind of difficult to show something in a video, which can not be done...
So let my try to explain it again.
When you take a look at your first page with the values 1-20, you can use the Drag & Drop functionality (grey boxes on the left side of each value) to drag a value and drop it at another spot of your list.
So for example it is possible to drag value 1 and move it down a few spots so that it is placed after value 5 for example.
This way the sort order of the values can be changed.
Can you confirm that this is possible on your instance as well?

My issue now is, that it is impossible to move a value to a spot on another page.
So it is possible to move value 1 somewhere on the first page, but there is no way to move value 1 to a spot on the second page, so for example between value 22 and 23.

This way the sort order possibilities are limited to movements on a specific page, which is a bug in my eyes, as the sort order can not be individualized completely.

I hope my explanation was clearer now, please let me know, if you still miss something.

@ajijshekh123
Copy link

Hello @norgeindian,
Thanks for the good clarifications. I understand your issue.
I think this is not an issue. This is a limitation set by the Magento Team.
Let me confirm this issue with a feature request.

Thanks.

@norgeindian
Copy link
Author

@ajijshekh123, thanks for confirming the issue.
To be honest, in my eyes this is actually a bug and no feature request.
There is obviously the possibility to change the order of the values, so it should be possible to change it for any value in my eyes and not only for groups of 20 values.
In Magento1 there was the possibility to adapt the order by adding an integer to each value. This worked with as many values as wanted.
So here Magento actually takes a step back in adding the Drag & Drop functionality and limiting the functionality to each page.
So please be so kind and think one more time about labeling this as a bug, because I don't think that this limitation was set on purpose or with a special aim in mind.
Thank you.

@ajijshekh123
Copy link

Okay, @norgeindian,
I understand your concern and your feedback.
Let me discuss with this issue the Magento team then update the label.

Thanks.

@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Aug 11, 2021
@m2-community-project m2-community-project bot removed this from Ready for Development in Low Priority Backlog Aug 11, 2021
@norgeindian
Copy link
Author

Is there any approach to fix this issue? It's really difficult for us to work with this issue.

@antonioglass
Copy link

Hey! I'm also waiting for a fix…

@bluedarter2
Copy link

bluedarter2 commented Feb 12, 2022

I'm waiting for a fix, or a work-around, for this too! I have products with 90 choices in the drop-down, they are dye color names fwiw, and I have NO WAY to add a new color name in the middle of the list - which I need to do to keep it in alphabetic order!

This is a horrid bug, or a seriously mal-designed "feature". The "Add Value" button automatically adds to the end of the list. The Customizable Options display ONLY displays up to 20 items per "page", and there is no way to move a new item across displayed "pages".

There is no way to resize the displayed list to display more than 20 items, and in such a way slowly move the new item to where it is wanted.

There is no way to "Add Value" to a particular place in the list.

@norgeindian
Copy link
Author

Any update here?

@norgeindian
Copy link
Author

This is still an issue on our side.

@norgeindian
Copy link
Author

@sdzhepa , any updates here?

@Team-MediaDivision
Copy link

easy..

https://magento.stackexchange.com/questions/294869/how-to-remove-pagination-from-customizable-options-backend-in-magento-2

i've changed the file in vendor directly. because i dont care.

magento/vendor/magento/module-ui/view/base/web/js/dynamic-rows.js

search for 20 - replace with 100.. or 1000... upgrade, cache clean, ready.

@norgeindian
Copy link
Author

@Team-MediaDivision , well, that is a workaround, but surely not the fix for the original issue.
@sdzhepa , any news reagrding this?

@sdzhepa
Copy link
Contributor

sdzhepa commented Aug 8, 2022

Hello @norgeindian

I do not have any updates. I do not work on this task directly just can check and summarise public and internal information.
Priority for the issue was raised to P2. It is still Ready for Development in both backlogs - Community and Internal.
It means that the issue still waiting for developer(s) from Community Contributors or Adobe teams who start progress and propose PR with a fix.

@norgeindian
Copy link
Author

@sdzhepa , thanks for the update. That's better than nothing. Please keep me updated.

@norgeindian
Copy link
Author

@sdzhepa , did the status change or is everything still the same?

@sdzhepa
Copy link
Contributor

sdzhepa commented Nov 16, 2022

Hello @norgeindian

As I can see the issue is still in "Progress: ready for dev" and does not have any assigned person
image

When someone from the public Community or internal team takes it in progress, the status "Progress: ready for dev" will change to something like "Dev in progress"

so, status still the same

@saurabhnxtgen
Copy link

easy..

https://magento.stackexchange.com/questions/294869/how-to-remove-pagination-from-customizable-options-backend-in-magento-2

i've changed the file in vendor directly. because i dont care.

magento/vendor/magento/module-ui/view/base/web/js/dynamic-rows.js

search for 20 - replace with 100.. or 1000... upgrade, cache clean, ready.

Legend

@Kannakiraj123
Copy link
Contributor

@magento I am working on this

@rogerdz
Copy link
Contributor

rogerdz commented Oct 25, 2023

Seem like it was fixed by allow the page size to be selected in the custom option
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: UI Framework Component: Admin Component: Catalog Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.3.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
High Priority Backlog
  
Ready for Development
Development

Successfully merging a pull request may close this issue.