Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Added missing translation for modal title & buttons on admin #28201

Closed
4 tasks
ghost opened this issue May 12, 2020 · 2 comments · Fixed by #28174
Closed
4 tasks

[Issue] Added missing translation for modal title & buttons on admin #28201

ghost opened this issue May 12, 2020 · 2 comments · Fixed by #28174
Assignees
@srsathish92
Labels
Component: CatalogInventory Component: Customer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Community Backlog

Comments

@ghost
Copy link

ghost commented May 12, 2020

This issue is automatically created based on existing pull request: #28174: Added missing translation for modal title & buttons on admin

Description (*)

Added missing translation for modal title & buttons in modal (Customers -> Add New Address, Edit Product -> Advanced Inventory) on Admin.

Related Pull Requests

NA

Manual testing scenarios (*)

  1. Magento/Customer/i18n/en_US.csv ("Add/Update Address","Test Add/Update Address")
  2. Go to Admin Customers -> Addresses -> Add New Address -> see Modal Title (Add/Update Address)
  3. Magento/CatalogInventory/i18n/en_US.csv ("Advanced Inventory","Test Advanced Inventory")
  4. Go to Admin Catalog -> products -> Edit/Add product -> click "Advanced Inventory" -> see Modal Title (Advanced Inventory) & Modal Button (Done)

Questions or comments

NA

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@srsathish92 srsathish92 mentioned this issue May 12, 2020
Merged
5 tasks
@ghost ghost assigned srsathish92 May 12, 2020
@ghost ghost added this to PR In Progress in Community Backlog May 12, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 12, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 12, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 21, 2020
@slavvka
Copy link
Member

slavvka commented May 21, 2020

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #28174 by @srsathish92 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@slavvka slavvka closed this as completed May 21, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog May 21, 2020
@ghost ghost added the Progress: done label May 21, 2020
@sdzhepa sdzhepa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 21, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 21, 2020
@magento magento deleted a comment from magento-engcom-team May 21, 2020
@magento-engcom-team
Copy link
Contributor

Based on the provided information internal tickets MC-34530 were created.

@sdzhepa sdzhepa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 21, 2020
@magento-engcom-team magento-engcom-team removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 21, 2020
@magento magento deleted a comment from magento-engcom-team May 21, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srsathish92 srsathish92

Labels
Component: CatalogInventory Component: Customer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing translation for modal title & buttons on admin srsathish92/magento2
4 participants
@sdzhepa @slavvka @srsathish92 @magento-engcom-team