Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price filter ignores inclusion of tax #28334

Open
maderlock opened this issue May 22, 2020 · 15 comments
Open

Price filter ignores inclusion of tax #28334

maderlock opened this issue May 22, 2020 · 15 comments
Labels
Component: Filter Component: Pricing Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog

Comments

@maderlock
Copy link

maderlock commented May 22, 2020 •
edited by engcom-Bravo

Preconditions

1.I have set Backend Catalog Price as a Excluding Tax And Front side Display Product Price in Catalog set as Including Tax.
2. Magento 2.3.3p2
3. Magento 2.4-develop

Steps to reproduce

Magento 2.3.3p2
Go to Backend and set this Tax Calculation configuration
Stores -> Configuration -> Sales -> Tax
46853224-19609900-ce1b-11e8-9d9a-c7043df60132

Stores -> Taxes -> Tax Zones and Rates
46853275-3b5a1b80-ce1b-11e8-8b46-79b159ef5de4

Stores -> Taxes -> Tax Rules
46853330-562c9000-ce1b-11e8-8add-1537e0066fdd

Go to Front end listing page and filter it by Price Range 40 to 50

Expected result

In listing Page After Price filter Display result between 40 to 50

Actual result

In listing Page After Price filter Display result in some products are displayed greater than 50. Please check below screen shot .
46853576-2e89f780-ce1c-11e8-89ca-d7265d07baf3
@ghost ghost added this to Ready for QA in Community Backlog May 22, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label May 22, 2020
@Sutharsan27 Sutharsan27 self-assigned this May 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2020

Hi @Sutharsan27. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@Sutharsan27
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Sutharsan27. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Sutharsan27, here is your Magento instance.
Admin access: https://i-28334-2-4-develop.instances.magento-community.engineering/admin_7193
Login: 13e7c30c Password: bbfe6f6fbab3
Instance will be terminated in up to 3 hours.

@Sutharsan27
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Sutharsan27. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@Sutharsan27
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Sutharsan27. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Dev In Progress in Low Priority Backlog Sep 24, 2020
@ghost ghost unassigned Sutharsan27 Oct 8, 2020
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Grooming in Low Priority Backlog Oct 8, 2020
@sidolov sidolov added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 21, 2020
@ghost ghost removed this from Ready for QA in Community Backlog Oct 21, 2020
@ghost ghost removed this from Ready for Grooming in Low Priority Backlog Oct 21, 2020
@ghost ghost added Issue: ready for confirmation and removed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Oct 21, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.3.3 Indicates original Magento version for the Issue report. label Nov 13, 2020
@engcom-Bravo engcom-Bravo self-assigned this Jan 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 5, 2021

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Jan 5, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 26, 2021

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Jan 26, 2021
@engcom-Charlie engcom-Charlie removed their assignment Jan 26, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Jan 26, 2021
@engcom-Hotel engcom-Hotel self-assigned this Jan 28, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2021

Hi @engcom-Hotel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Jan 28, 2021
@engcom-Hotel engcom-Hotel removed their assignment Jan 28, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Jan 28, 2021
@blmage
Copy link
Contributor

blmage commented May 26, 2021

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog May 26, 2021
@blmage blmage mentioned this issue Jun 2, 2021
Closed
5 tasks
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Jun 2, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Filter Component: Pricing Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for dev Reported on 2.3.3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
High Priority Backlog
  
Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix price discrepancies with some tax configurations blmage/magento2
8 participants
@maderlock @blmage @magento-engcom-team @Sutharsan27 @vlmed @engcom-Bravo @engcom-Charlie @engcom-Hotel