Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Clean expired quotes - Fix out of memory on huge quotes list #28342

Closed
4 tasks
ghost opened this issue May 22, 2020 · 2 comments · Fixed by #27260
Closed
4 tasks

[Issue] Clean expired quotes - Fix out of memory on huge quotes list #28342

ghost opened this issue May 22, 2020 · 2 comments · Fixed by #27260
Assignees
@ihor-sviziev
Labels
Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Community Backlog

Comments

@ghost
Copy link

ghost commented May 22, 2020

This issue is automatically created based on existing pull request: #27260: Clean expired quotes - Fix out of memory on huge quotes list

Description (*)

On production we had a lot of expired quotes, and during cron run we were getting fatal error:

PHP Fatal error:  Allowed memory size of 2147483648 bytes exhausted (tried to allocate 20480 bytes) in /path/to/magento2/vendor/magento/framework/Model/AbstractModel.php on line 359

Check https://getcomposer.org/doc/articles/troubleshooting.md#memory-limit-errors for more info on how to handle out of memory errors.

Investigation found that cron job sales_clean_quotes fails with out of memory because it tries to load all quote items at once

Related Pull Requests

N/A

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@ghost ghost added Component: Sales Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels May 22, 2020
@ihor-sviziev ihor-sviziev mentioned this issue May 22, 2020
Merged
5 tasks
@ghost ghost assigned ihor-sviziev May 22, 2020
@ghost ghost added this to PR In Progress in Community Backlog May 22, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 22, 2020
@sdzhepa sdzhepa linked a pull request May 22, 2020 that will close this issue
Clean expired quotes - Fix out of memory on huge quotes list #27260
Merged
5 tasks
@magento magento deleted a comment from magento-engcom-team May 22, 2020
@magento magento deleted a comment from magento-engcom-team May 22, 2020
@magento-engcom-team magento-engcom-team added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label May 22, 2020
@magento-engcom-team
Copy link
Contributor

Based on the provided information internal tickets MC-34583 for 2.4.x were created.

@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label May 22, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 5, 2020
@slavvka
Copy link
Member

slavvka commented Jun 5, 2020

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #27260 by @ihor-sviziev in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka closed this as completed Jun 5, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 5, 2020
@ghost ghost added the Progress: done label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ihor-sviziev ihor-sviziev

Labels
Component: Sales Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clean expired quotes - Fix out of memory on huge quotes list ihor-sviziev/magento2
4 participants
@ihor-sviziev @sdzhepa @slavvka @magento-engcom-team