Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect CSS selector in shipment page #28345

Closed
yavuz opened this issue May 23, 2020 · 4 comments · Fixed by #28639
Closed

Incorrect CSS selector in shipment page #28345

yavuz opened this issue May 23, 2020 · 4 comments · Fixed by #28639
Assignees
@mrtuvn
Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Community Backlog

Comments

@yavuz
Copy link

yavuz commented May 23, 2020

magento2/app/code/Magento/Sales/view/frontend/templates/order/print/shipment.phtml

Line 64 in c9a246a

<div class="box box-order-billing-method">

I think this line should be like this.

<div class="box box-order-billing-address">

Am I wrong?
@m2-assistant
Copy link

m2-assistant bot commented May 23, 2020

Hi @yavuz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

@ghost ghost added this to Ready for QA in Community Backlog May 23, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label May 23, 2020
@mrtuvn mrtuvn mentioned this issue Jun 9, 2020
Closed
5 tasks
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Jun 9, 2020
@ghost ghost added Progress: PR in progress Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Progress: ready for QA labels Jun 9, 2020
@ghost ghost moved this from PR In Progress to Ready for QA in Community Backlog Jun 9, 2020
@mrtuvn mrtuvn mentioned this issue Jun 9, 2020
Merged
5 tasks
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Jun 9, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Jun 17, 2020 •
edited
Loading

Hello @yavuz
fyi: @mrtuvn

Could you please provide more details about the issue?

  • How it impacts product or functionality?
  • What functional flows are broken due to this issue?
  • what is the business value?

Or its just typo that does not affect any functionality?

@mrtuvn
Copy link
Contributor

mrtuvn commented Jun 17, 2020

@sdzhepa for me just clean up code remove deprecated method call in previous. Validate code and correct class follow correct context inside

@m2-assistant m2-assistant bot mentioned this issue Jul 24, 2020
Closed
@ghost ghost assigned mrtuvn Jul 24, 2020
@ghost ghost removed the Progress: needs update label Jul 24, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 27, 2020
@slavvka
Copy link
Member

slavvka commented Jul 29, 2020

Hi @yavuz. Thank you for your report.
The issue has been fixed in #28639 by @mrtuvn in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jul 29, 2020
@slavvka slavvka closed this as completed Jul 29, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrtuvn mrtuvn

Labels
Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup duplicate html class mrtuvn/magento2
Cleanup html class duplicate mrtuvn/magento2
6 participants
@yavuz @mrtuvn @sdzhepa @VladimirZaets @slavvka @magento-engcom-team