Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] [PERF Improvements]Load polyfills for browsers that don't support certain features #28382

Closed
5 tasks
ghost opened this issue May 27, 2020 · 2 comments · Fixed by #27618
Closed
5 tasks

[Issue] [PERF Improvements]Load polyfills for browsers that don't support certain features #28382

ghost opened this issue May 27, 2020 · 2 comments · Fixed by #27618
Assignees
@krzksz
Labels
Component: Ui Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Community Backlog

Comments

@ghost
Copy link

ghost commented May 27, 2020 •
edited by VladimirZaets
Loading

Here I'm using RequireJS configuration and the whole deps mechanism to conditionally load browser features polyfils only when needed. Changes in this PR include:

Preconditions (*)

  1. Magento version 2.3.5

Steps to reproduce (*)

Expected result (*)

UI components, e.g. in checkout or admin are still functional.
Polyfills for Map, WeakMap, FormData and MutationObserver are loaded only for old browsers that do not support them.

Actual result (*)

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@ghost ghost added Component: Ui Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 27, 2020
@krzksz krzksz mentioned this issue May 27, 2020
Merged
5 tasks
@ghost ghost assigned krzksz May 27, 2020
@ghost ghost added this to PR In Progress in Community Backlog May 27, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels May 27, 2020
@VladimirZaets VladimirZaets added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 27, 2020
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 27, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @VladimirZaets
Thank you for verifying the issue. Based on the provided information internal tickets MC-34672 were created

Issue Available: @VladimirZaets, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added the Triage: Done Has been reviewed and prioritized during Triage with Product Managers label May 28, 2020
@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Jun 5, 2020
@slavvka
Copy link
Member

slavvka commented Jun 5, 2020

Hi @m2-backlog[bot]. Thank you for your report.
The issue has been fixed in #27618 by @krzksz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka closed this as completed Jun 5, 2020
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Jun 5, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krzksz krzksz

Labels
Component: Ui Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[PERF Improvements]Load polyfills for browsers that don't support certain features krzksz/magento2
5 participants
@krzksz @sdzhepa @VladimirZaets @slavvka @magento-engcom-team