Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single mutation for Add to Cart that supports all product types #28524

Closed
nrkapoor opened this issue Apr 9, 2020 · 2 comments · Fixed by #27914
Closed

Single mutation for Add to Cart that supports all product types #28524

nrkapoor opened this issue Apr 9, 2020 · 2 comments · Fixed by #27914
Assignees
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Partner: Atwix Pull Request is created by partner Atwix Project: GraphQL
Milestone

Comments

@nrkapoor
Copy link

nrkapoor commented Apr 9, 2020

Right now we have 7 mutations for adding different types of products to the cart. When we started working on wishlist functionality it turned out that we will have to create 14 more mutations (adding to wishlist and moving from wishlist to cart). It leads to overcomplicated flow and does not help to improve developers' experience.

Expected behavior
A single mutation is used to add all types of products to the cart.
Supported Product Types

Simple
Configurable
Virtual
Downloadable
Bundled
Gift Card
Grouped

Acceptance Criteria
All product types can be added to the cart with a single mutation.
User-friendly errors are returned in case the add to cart operation is unsuccessful.
All existing Add to Cart tests must pass for the new mutation.

Benefits
Less code complexity

Additional information
Approved Schema

@nrkapoor nrkapoor assigned nrkapoor and rogyar and unassigned nrkapoor Apr 9, 2020
@nrkapoor nrkapoor transferred this issue from magento/community-features Jun 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2020

Hi @nrkapoor. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for QA in Community Backlog Jun 4, 2020
@nrkapoor nrkapoor moved this from Ready for QA to Dev in Progress in Community Backlog Jun 4, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 4, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 4, 2020

Hi @rogyar. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ghost ghost moved this from Dev in Progress to PR In Progress in Community Backlog Jun 4, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@nrkapoor nrkapoor added the Partner: Atwix Pull Request is created by partner Atwix label Jun 9, 2020
@ghost ghost assigned andrewbess Jun 15, 2020
@andrewbess andrewbess removed their assignment Jun 15, 2020
@nrkapoor nrkapoor linked a pull request Jun 17, 2020 that will close this issue
4 tasks
@ghost ghost assigned andrewbess Jun 18, 2020
@prabhuram93 prabhuram93 removed a link to a pull request Jul 9, 2020
4 tasks
@ghost ghost moved this from PR In Progress to Done (last 30 days) in Community Backlog Aug 11, 2020
@andrewbess andrewbess removed their assignment Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Partner: Atwix Pull Request is created by partner Atwix Project: GraphQL
Projects
No open projects
Community Backlog
  
Done (last 30 days)
4 participants