Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL- preview for a disabled product returns empty response #28575

Closed
magento-engcom-team opened this issue Jun 5, 2020 · 6 comments
Closed
Assignees
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone

Comments

@magento-engcom-team
Copy link
Contributor

Steps to reproduce:

  1. Create a product that is in stock, assigned to a category, and set the status to disable
  2. Create an update for the product that enables it
  3. Run the below query with authorization token and preview-version header
{
   products
   (filter:{sku:{eq:"disabled-simple"}})
    {
      items{
        sku
        name
        stock_status
        price_range{
          maximum_price{
            final_price{value}
            regular_price{value}
        }
        minimum_price{
          final_price{value}
          regular_price{value}
        }
      }
    }
  }
}

#####Expected Result:
Product data is returned

#####Actual Result:
Product data is empty

@magento-engcom-team magento-engcom-team added Progress: ready for dev Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @magento-engcom-team. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


@ghost ghost added this to Ready for Dev in Community Backlog Jun 5, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jun 5, 2020
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 5, 2020
@nrkapoor nrkapoor moved this from Ready for Dev to Good First Issue in Community Backlog Jun 10, 2020
@alfredsgenkins
Copy link

I believe this is related to Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Product\CollectionProcessor\StockProcessor class.

For some reason it seems to return wrong value, despite adding only following lines to SQL QUERY:

... INNER JOIN `cataloginventory_stock_status` AS `stock_status_index` ON e.entity_id = stock_status_index.product_id AND stock_status_index.website_id = 0 AND stock_status_index.stock_id = 1 ... AND (stock_status_index.stock_status=1)

I did reindex after disabling product, which did not help. Maybe my observations are wrong :)

@alfredsgenkins
Copy link

Maybe disabled products do not appear in cataloginventory_stock_status? I can only see 1 in stock_status column.

@pmarjan pmarjan self-assigned this Jun 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @pmarjan. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Good First Issue to Dev in Progress in Community Backlog Jun 13, 2020
@pmarjan pmarjan removed their assignment Jun 15, 2020
@ghost ghost moved this from Dev in Progress to Ready for QA in Community Backlog Jun 15, 2020
@danielrenaud danielrenaud moved this from Ready for QA to Ready for Dev in Community Backlog Jun 15, 2020
@gallyamov gallyamov self-assigned this Jun 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @gallyamov. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@ghost ghost moved this from Ready for Dev to Dev in Progress in Community Backlog Jun 18, 2020
@danielrenaud
Copy link
Contributor

Caused by core functionality that can not be fixed at this time

@ghost ghost moved this from Dev in Progress to Done (last 30 days) in Community Backlog Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed PAP Partners acceleration program Project: GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Development

No branches or pull requests

7 participants