Custom Admin Domain and Internal Redirects

[pocallaghan]

The logic that checks if a redirect is "internal" is broken in the admin panel when using a custom admin domain, which causes a wide variety of admin redirects to redirect you to the homepage of the default store.

The issue is due to Magento\Store\App\Response\Redirect::_isUrlInternal using the default stores base url. When in the adminhtml area, this method should respect the config options admin/url/use_custom and admin/url/custom.

Preconditions (*)

1. Magento 2.4-develop
2. Custom admin domain set under Stores > Configuration > Advanced > Admin > Admin Base Url > Custom Admin Url
   
3. For local environment: Create additional virtualhost for url http://admin.magento2dev.loc and add admin.magento2dev.loc to hosts file

<VirtualHost *:80>
    ServerName          magento2dev.loc
    ServerAlias magento2dev.loc
    DocumentRoot        /var/www/html/magento2dev
<Directory /var/www/html/magento2dev/>
                Options Indexes FollowSymLinks MultiViews
                AllowOverride All
                Order allow,deny
                allow from all
Require all granted
</Directory>
 </VirtualHost>


<VirtualHost *:80>
    ServerName          admin.magento2dev.loc
    DocumentRoot        /var/www/html/magento2dev
<Directory /var/www/html/magento2dev/>
                Options Indexes FollowSymLinks MultiViews
                AllowOverride All
                Order allow,deny
                allow from all
Require all granted
</Directory>
 </VirtualHost>

Steps to reproduce (*)

1. Log in to an account with access to URL Rewrites
2. Navigate to Marketing > URL Rewrites
3. Click Add Url Rewrite
4. Enter 123456789 as the request path and 987654321 as the target path, then hit save.
5. Click Add Url Rewrite again
6. Enter 123456789 as the request path and xyz as the target path, then hit save.

Expected result (*)

1. Expected to be redirected back to the URL Rewrite Edit page with an error message Request Path for Specified Store already exists.

Actual result (*)

1. You're redirected to the homepage of the default store.
   

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @pocallaghan. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Lima]

Hello @pocallaghan

Could you confirm that the result will be the same as when using the CLI?
php bin/magento setup:config:set --backend-frontname="newadminpath"
Where newadminpath - new Custom Admin URL
I checked on the Magento 2.4 using CLI and cannot reproduce the issue

[pocallaghan]

That is not the same setting, you're setting the "frontname", not the domain name.

[engcom-Lima]

Hello @pocallaghan
Could you show how are you configure Custom admin domain under Stores > Configuration > Advanced > Admin > Admin Base Url > Custom Admin Url?
It would be great if you attached the GIF file.
I checked versions 2.4, 2.3.5 and 2.3.4-p2 and every time I got an error

[sunel]

@engcom-Lima

This is long pending issue #12354

[pocallaghan]

@engcom-Lima you're likely to be unable to replicate in what ever environment you're trying it in. Changing the domain name of the admin panel requires DNS entries to be added so that the domain name you enter points at the same location as the main stores domain and potentially updates to the server hosting configuration so that the domain loads the right VirtualHost. @sunel it is indeed the same issue, but the ticket was marked as non-issue with no good reason. It is 100% an issue.

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[magento-engcom-team]

✅ Confirmed by @engcom-Delta
Thank you for verifying the issue. Based on the provided information internal tickets MC-35680 were created

Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 2. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[HenKun]

This issue also arises, when the default store domain has a subfolder like https://www.example.com/en-us/.
Then in _isUrlInternal() the check fails because https://www.example.com/admin/... does not contain https://www.example.com/en-us/. It's the same reason.

[engcom-Alfa]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @engcom-Alfa. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @engcom-Alfa, here is your Magento instance.
Admin access: https://i-28943-2-4-develop.instances.magento-community.engineering/admin_492c
Login: 0388e944 Password: d6a6f1c51ae8
Instance will be terminated in up to 3 hours.

[magento-engcom-team]

Hi @pocallaghan. Thank you for your report.
The issue has been fixed in #29066 by @engcom-Charlie in 2.4-develop branch
Related commit(s):

• c5b320bd105e67d7ceeb86f42fdb1b08367e9a2f

The fix will be available with the upcoming 2.4.1 release.