Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defined conditions not visible in edit mode for widget Catalog Products List #2913

Closed
twiking opened this issue Jan 7, 2016 · 18 comments
Closed
Assignees
Labels
bug report Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@twiking
Copy link

twiking commented Jan 7, 2016

Steps to repeat

  1. Go to Admin -> Content -> Pages, and edit a page.
  2. Add a new widget to the page
  3. Select Catalog Product Lists as the widget type.
  4. Create a condition
  5. Select Product attribute -> Category
  6. Click on ... and select a category
  7. Insert the widget
  8. Click on "Save and Continue Edit"
  9. Double click on the widget (with WYSIWYG editor mode enabled)

Expected result: The defined conditions should be shown.
Actual result: The defined conditions are not shown.

The conditions are saved correctly. Confirmed by looking at the source

{{widget type="Magento\CatalogWidget\Block\Product\ProductsList" title="Product Top List" products_count="10" template="product/widget/content/grid.phtml" conditions_encoded="a:2:[i:1;a:4:[s:4:`type`;s:50:`Magento|CatalogWidget|Model|Rule|Condition|Combine`;s:10:`aggregator`;s:3:`all`;s:5:`value`;s:1:`1`;s:9:`new_child`;s:0:``;]s:4:`1--1`;a:4:[s:4:`type`;s:50:`Magento|CatalogWidget|Model|Rule|Condition|Product`;s:9:`attribute`;s:12:`category_ids`;s:8:`operator`;s:2:`==`;s:5:`value`;s:1:`6`;]]"}}

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36.
JS errors: None

@shiftedreality
Copy link
Member

@twiking, thank you for reporting!

Internal ticket MAGETWO-47858 was created

@facundocapua
Copy link
Contributor

Is there any update on this issue?

@ghost
Copy link

ghost commented Oct 24, 2016

Hi Is there any update on this?

@veloraven veloraven added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 26, 2016
@olysenko
Copy link

olysenko commented Nov 7, 2016

Hi, this issue is not reproducible(fixed) on develop branch. For now it is all update

@wigman
Copy link
Contributor

wigman commented Nov 7, 2016

Hello @olysenko,

I don't exactly get what you are saying. Is the problem solved in develop branch? I'm currently running Magento CE 2.1.2 in development mode and encounter the same problem.

@olysenko
Copy link

olysenko commented Nov 7, 2016

@wigman Yes this problem is solved in develop branch, but not in 2.1

@wigman
Copy link
Contributor

wigman commented Nov 8, 2016

@olysenko ok, great. would you happen to know the commit where it was fixed? That way I can cook up a patch. Thanks a lot!

@spyrule
Copy link

spyrule commented Nov 25, 2016

yes, please post a link to the known commit ... some of us cannot wait for the major patch release.

@gabs77
Copy link

gabs77 commented Jan 9, 2017

Please, someone know the patch or the commit about that ?

@koenner01
Copy link
Contributor

koenner01 commented Feb 9, 2017

Can we please get a commit reference; Like @spyrule said, some of us CANNOT wait for the slow machine of the major releases.

This is a pressing issue and causing real problems for clients.

@koenner01
Copy link
Contributor

Ok I looked into this further (because we cannot wait on official Magento response) and the commit where this issue is fixed is 49d7b065efa

@kanduvisla
Copy link
Contributor

Any update on this? It still persists in Magento 2.1.4

@leptoquark1
Copy link

Since this has a commit from 6 Jul 2016: When is this gonna be released?

@christian-forgacs
Copy link

christian-forgacs commented Apr 25, 2017

Not released with Magento 2.1.6...

@kishorhase
Copy link

kishorhase commented Jun 12, 2017

Conditions are actually saved, but does not restored when edit the widget.
Any update on this? Issue still persist in Magento ver. 2.1.7

@bhargavlalo
Copy link

Yes same issue in Magento ver 2.1.7. Also condition not properly work on frontend. Any update on it?

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@twiking, thank you for your report.
We were not able to reproduce this issue by following the steps you provided. If you'd like to update it, please reopen the issue.
We tested the issue on 2.3.0-dev, 2.2.0, 2.1.9

@magento-engcom-team magento-engcom-team added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Oct 13, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 13, 2017
@christian-forgacs
Copy link

@magento-engcom-team we can confirm, that the issue is fixed in our project with 2.1.9. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests