Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Unit Test / Bugfix / Inverted Expected value with actual one #29283

Closed
4 tasks
m2-assistant bot opened this issue Jul 27, 2020 · 1 comment · Fixed by #29271
Closed
4 tasks

[Issue] Unit Test / Bugfix / Inverted Expected value with actual one #29283

m2-assistant bot opened this issue Jul 27, 2020 · 1 comment · Fixed by #29271
Assignees
@lbajsarowicz
Labels
Component: Newsletter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Community Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2020

This issue is automatically created based on existing pull request: #29271: Unit Test / Bugfix / Inverted Expected value with actual one

Description (*)

The values were compared invalid way (opposite): expected vs actual values.
I swapped them, also verified if there are no such examples across the platform, but haven't found any other.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

N/A

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@lbajsarowicz lbajsarowicz mentioned this issue Jul 27, 2020
Merged
5 tasks
@ghost ghost assigned lbajsarowicz Jul 27, 2020
@ghost ghost added this to Ready for QA in Community Backlog Jul 27, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Jul 27, 2020
@ghost ghost added Progress: ready for QA Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jul 27, 2020
@slavvka
Copy link
Member

slavvka commented Aug 1, 2020

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #29271 by @lbajsarowicz in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 1, 2020
@slavvka slavvka closed this as completed Aug 1, 2020
@ghost ghost moved this from Ready for QA to Done (last 30 days) in Community Backlog Aug 1, 2020
@sdzhepa sdzhepa mentioned this issue May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbajsarowicz lbajsarowicz

Labels
Component: Newsletter Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit Test / Bugfix / Inverted Expected value with actual one lbajsarowicz/magento2
3 participants
@lbajsarowicz @slavvka @magento-engcom-team