Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Update code to reduce redundancy and simplify readability #29381

Closed
4 tasks done
m2-assistant bot opened this issue Aug 4, 2020 · 2 comments · Fixed by #28608
Closed
4 tasks done

[Issue] Update code to reduce redundancy and simplify readability #29381

m2-assistant bot opened this issue Aug 4, 2020 · 2 comments · Fixed by #28608
Labels
Component: App Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Community Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 4, 2020 •
edited by engcom-Alfa
Loading

This issue is automatically created based on existing pull request: #28608: Update code to reduce redundancy and simplify readability

Simplified code complexity by optimizing logic, redundant variable assignments, over-usage of returns within a function. Eliminated needless and redundant variable assignment.

Preconditions: (*)

Simplifying logic and readability randomly

Steps to reproduce (*)

  1. Modified functions are simpler yet do not change any logic within lib/internal/Magento/Framework/App/Request/Http.php

Actual Result:

Expected Result:

Questions or comments

No.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: App Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 4, 2020
@df2k2 df2k2 mentioned this issue Aug 4, 2020
Merged
5 tasks
@ghost ghost added this to Ready for QA in Community Backlog Aug 4, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 4, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 4, 2020
@engcom-Alfa engcom-Alfa added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Aug 4, 2020
@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Aug 4, 2020
@engcom-Alfa engcom-Alfa added Triage: Done Has been reviewed and prioritized during Triage with Product Managers Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 4, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-36438 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: ready for dev and removed Progress: PR in progress labels Aug 4, 2020
@ghost ghost moved this from PR In Progress to Ready for Dev in Community Backlog Aug 4, 2020
@slavvka
Copy link
Member

slavvka commented Aug 8, 2020

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #28608 by @df2k2 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.1 release.

@slavvka slavvka added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Aug 8, 2020
@slavvka slavvka closed this as completed Aug 8, 2020
@ghost ghost moved this from Ready for Dev to Done (last 30 days) in Community Backlog Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: App Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
No open projects
Community Backlog
  
Done (last 30 days)
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update code to reduce redundancy and simplify readability df2k2/magento2
3 participants
@slavvka @magento-engcom-team @engcom-Alfa