-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Performance] Slow product edit page with big amount of custom options #29409
Comments
Hi @ihor-sviziev. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento 2.4-develop instance for you |
Hi @ihor-sviziev, here is your Magento instance. |
Just checked - unfortunately it's not fixed the issue |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions! |
Still actual |
Hi @engcom-Delta. Thank you for working on this issue.
|
If someone is brave enough to dig in, I guess that a start would be to replace Array functions, especially in dom-observer.js See https://leanylabs.com/blog/js-forEach-map-reduce-vs-for-for_of/ |
Hello, i've same problem on my magento 2.4.4 my product have 1500 custom options and load time is 7sec. Do you have find a solution? Thanks a lot |
I have the same problem with the Bundle Product edit page. As @pmonosolo described, the more options and selections a Bundle has, the more time it takes to load the page. As @Nuranto suggested, I replaced all the
becomes
But what really does the trick for me, was to get rid of all the
becomes
With these simple changes I was able to decrease the page load time for one of my Bundle Products from about 1min 20sec to 35sec. I'd be interested to know if these changes also improve page load time for products with custom options (I don't have any of those). |
@densen45, could you please create a Pull Request with your changes? So that we can run automated tests on top of them |
@magento I am working on this |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-9127 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Lima. Thank you for verifying the issue. |
Preconditions (*)
Steps to reproduce (*)
export_catalog_product_20200805_133448.zip
Expected result (*)
Actual result (*)
Here is performance profile from Google Chrome extension:
Profile-20200805T162549.zip
Use case
We would like to provide our customers an ability to customize amount and colors of stones on the product (up to 8 stones, in example each color named as month for simplicity of example).
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: