Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Added processing of missed 'Fields enclosure' on admin exports #29554

Open
m2-assistant bot opened this issue Aug 14, 2020 · 4 comments · May be fixed by #27830
Open

[Issue] Added processing of missed 'Fields enclosure' on admin exports #29554

m2-assistant bot opened this issue Aug 14, 2020 · 4 comments · May be fixed by #27830
Assignees
Labels
Area: Import / export Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 14, 2020

This issue is automatically created based on existing pull request: #27830: Added processing of missed 'Fields enclosure' on admin exports


Description

The value of "Fields Enclosure" checkbox on admin export page (System -> Export) is not passed to appropriate export model, therefore enclosure behavior is not handled.
This Pull Request is fixing that.

Manual testing scenarios

  1. Ensure you have some products and custom attributes.
  2. Export products through backend with the parameters:
  • Entity Type: Products
  • Export File Format: CSV
  • Fields Enclosure: Yes
  1. Download and open generated CSV file.

All attribute values in additional_attributes column must be wrapped by double quotes ", but they aren't.

Related Issues

Probably, it's worth to mention here closed issue #14642, there was the similar problem with skip_attr field.

@ghost ghost added this to Ready for QA in Community Backlog Aug 14, 2020
@ghost ghost moved this from Ready for QA to PR In Progress in Community Backlog Aug 14, 2020
@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Aug 14, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 14, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@sidolov sidolov added this to Ready for Grooming in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot moved this from Ready for Grooming to Pull Request In Progress in Low Priority Backlog Sep 24, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Sep 24, 2020
@engcom-Dash engcom-Dash self-assigned this Mar 7, 2024
Copy link
Author

m2-assistant bot commented Mar 7, 2024

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
    1. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@m2-community-project m2-community-project bot removed this from PR In Progress in Community Backlog Mar 7, 2024
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Mar 7, 2024
@engcom-Dash
Copy link

Hi @elevinskii

Thanks for reporting and collaboration.

Verified the issue in magento 2.5 dev instance and the issue is reproduced. Hence, confirming the issue.

All attribute values in additional_attributes column must be wrapped by double quotes ", but they aren't.

Please refer the screenshot attached.

Screenshot 2024-03-07 at 7 12 29 PM

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Import / export labels Mar 7, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11521 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Mar 7, 2024

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Import / export Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Priority: P3 May be fixed according to the position in the backlog. Progress: PR in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Pull Request In Progress
Development

Successfully merging a pull request may close this issue.

4 participants